Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KRUSTY 15 Cents Reactivity Insertion Model #478

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

miaoyinb
Copy link
Collaborator

closes #477

@miaoyinb
Copy link
Collaborator Author

@ycao-anl FYI

@moosebuild
Copy link

moosebuild commented Nov 27, 2024

Job VTB Documentation, step Sync Docs on a02dd53 wanted to post the following:

View the site here

This comment will be updated on new commits.

@miaoyinb miaoyinb marked this pull request as ready for review November 28, 2024 16:23
@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 2, 2024

@GiudGiud This is to add a transient model to the existing KRUSTY model. Thanks in advance for your review.

Copy link
Collaborator

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you ll want to add a few tags to the main krusty page, mainly RIA ?

any ideas for testing? can we regenerate the checkpoint file in a testing run (ideal) ?

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 2, 2024

you ll want to add a few tags to the main krusty page, mainly RIA ?

any ideas for testing? can we regenerate the checkpoint file in a testing run (ideal) ?

RIA might not be the ideal term as this is a warm critical test instead of an accident test. Maybe just use "warm critical test"?

Testing could be tricky as it will rely on the steady-state simulation checkpoint/SolutionVector output files, which also depend on the mpi ranks used. Any suggestion?

Co-authored-by: Guillaume Giudicelli <[email protected]>
@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 2, 2024

Running the steady case then running the transient is the easiest.

which also depend on the mpi ranks used. Any suggestion?

alternatively, if we LFS checked in the steady checkpoint we would have to be mindful of that

@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 2, 2024

there s a model under "Reactivity Insertion" already, for MR drum. could go with that one?

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 2, 2024

Running the steady case then running the transient is the easiest.

It takes ~4 hours on 10 sawtooth nodes to finish SN(2,3) NA=3 steady state.

Maybe we can try SN(1,3) NA=1 and force it to finish after one Richardson iteration and start the transient to run one timestep?

@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 2, 2024

we can try something like that though we wont see a steady state in the beginning of the transient

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 2, 2024

Let's try to see how long it takes to run such a case.

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 3, 2024

Good news: SN(1,3) NA=1 steady state with one Richardson iteration takes ~1000 seconds to run using 40 cores on a sawtooth node.
Bad news: the corresponding transient case using SN(1,3) NA=1 does not have enough memory to run on a single node. (it needs more nodes + distributed mesh to relieve the memory burden on each node.)

Maybe we can run the "simplified" steady-state case and then do syntax check only for the transient?

@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 3, 2024

can we reduce the mesh maybe?

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 3, 2024

Let me try

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 4, 2024

Reducing axial mesh density works. Using SN(1,3) NA=1 and allowing Richardson iteration to converge, the steady-state run takes ~2 hours and one time step transient takes about 500 seconds. I guess, this is okay for a "heavy" test.

@miaoyinb
Copy link
Collaborator Author

miaoyinb commented Dec 5, 2024

Added the tests. It seems the syntax override+!include does not like cli_args. I had to add an input file for testing.

@miaoyinb
Copy link
Collaborator Author

@GiudGiud Let me know if these tests are okay or if you have any additional comments. Thanks.

@GiudGiud
Copy link
Collaborator

Will do.
Need to get a submodule update done first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 15 Cent Reactivity Insertion to the KRUSTY Model
3 participants