[opponents-hand] minor quality changes

iee-ihu-gr-course1941 · Dec 15, 2024 · ce52bdb · ce52bdb
1 parent a9cef37
commit ce52bdb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/resources/js/Game/Board/OpponentsPiece/OpponentPiece.tsx b/resources/js/Game/Board/OpponentsPiece/OpponentPiece.tsx
@@ -13,7 +13,7 @@ const geometry = new THREE.BoxGeometry(0.5,0.5,0.5);
 export const OpponentPiece = memo(
     ({block_positions,destination,opponent}: Props) => {
 
-    const INITIAL_POSITION = new THREE.Vector3(0, 2, -5);
+    const ORIGIN_POSITION = new THREE.Vector3(0, 2, -5);
 
     const blockSize = useGameDimensions(state => state.blockSize);
     const addBoardPiece = useBoardState(state => state.addBoardPiece);
@@ -58,7 +58,7 @@ export const OpponentPiece = memo(
             gsap.to(ref.current.position, {
                 z: destinationPosition.z,
                 x: destinationPosition.x,
-                duration: calculateDuration(INITIAL_POSITION),
+                duration: calculateDuration(ORIGIN_POSITION),
                 onComplete: onComplete.current,
             });
         }
@@ -67,7 +67,7 @@ export const OpponentPiece = memo(
 
     return (
         <>
-            <group ref={ref} position={INITIAL_POSITION}>
+            <group ref={ref} position={ORIGIN_POSITION}>
                 {
                     block_positions.map((position, index) => {
                         return (

diff --git a/resources/js/Game/Board/OpponentsPiece/OpponentsHand.tsx b/resources/js/Game/Board/OpponentsPiece/OpponentsHand.tsx
@@ -19,7 +19,7 @@ export const OpponentsHand = () => {
             const randomX = Math.round((((Math.random() - 0.5) * 10)) / blockSize) * blockSize;
             const randomY = Math.round((((Math.random() - 0.5) * 10)) / blockSize) * blockSize;
             const opponentMovePayload: OpponentMovePayload = {
-                block_positions: PiecePositions[Math.floor(Math.random() * 20) as PieceCode],
+                block_positions: PiecePositions[occupations.length as PieceCode],
                 destination: {x: randomX, y: randomY},
                 opponent: 'green',
             }

diff --git a/resources/js/types/piece.ts b/resources/js/types/piece.ts
@@ -34,7 +34,7 @@ export type GameState = {
 }
 
 export type OpponentMovePayload = {
-    block_positions: Vector2[];
+    block_positions: Vector2[]
     destination: Vector2;
     opponent: PlayerIdentifier;
 }