Remove Rails dependency (version bump 2.5.0)

[nimmolo]

This commit removes Rails as a dependency, requiring only the Rails component gems/classes necessary to run Rails DB. It is intended to make the gem more compatible with Rails apps that are similarly configured. Tests are passing for me.

• Note that the require statements in bin/rails and test/config/application.rb are now more specific — they must specifically require the classes loaded by the gems, not just require 'rails'. The list is slightly different from the gem list, but this is a fairly standard setup that was easy to find examples on the web.

• I moved the gemfiles list into rails_db.gemspec. I believe that with gems, the .gemspec takes precedence over Gemfile, and is redundant where the Gemfile lists gemspec. When the gems were listed in both places, Bundler was complaining that several gems were included twice.

• I read in several places that for gem development, the Gemfile.lock should not be checked into version control. So I added it to .gitignore, but it doesn't seem to be ignored :) Anyway you can check the differences.

• In test_helper.rb, to get the rails version, it's now checking the version of activerecord, which should always be the same as Rails anyway.

[igorkasyanchuk]

did you tried to run rails_db ? (I mean executables if works too?)

[igorkasyanchuk]

and runsql

[nimmolo]

agh! You're right, the executables don't work. Only the GUI. Sorry i didn't catch that before.

standalone.rb is throwing an error when i try to run railsdb, it says that

/home/vagrant/.rvm/gems/ruby-3.0.4/gems/rack-2.2.4/lib/rack/handler/webrick.rb:26:in `run': 
wrong number of arguments (given 2, expected 1) (ArgumentError)

If I eliminate the options hash in line 46 of standalone.rb, it seems to launch but is not available at port :12345, it uses the WEBrick default port :8080. However, the Rack::Handler::WEBrick method run clearly should accept two arguments, app and options.

module Rack
  module Handler
    class WEBrick < ::WEBrick::HTTPServlet::AbstractServlet
      def self.run(app, **options)
        environment  = ENV['RACK_ENV'] || 'development'
        default_host = environment == 'development' ? 'localhost' : nil

        if !options[:BindAddress] || options[:Host]
          options[:BindAddress] = options.delete(:Host) || default_host
        end
        options[:Port] ||= 8080
        if options[:SSLEnable]
          require 'webrick/https'
        end

        @server = ::WEBrick::HTTPServer.new(options)
        @server.mount "/", Rack::Handler::WEBrick, app
        yield @server  if block_given?
        @server.start
      end

      def self.valid_options
        environment  = ENV['RACK_ENV'] || 'development'
        default_host = environment == 'development' ? 'localhost' : '0.0.0.0'

        {
          "Host=HOST" => "Hostname to listen on (default: #{default_host})",
          "Port=PORT" => "Port to listen on (default: 8080)",
        }
      end
...

If you have a chance, maybe you can help me debug why these two executables aren't launching.

[igorkasyanchuk]

interesting PR, thanks, need to think more about it.

Just to confirm - you have reduced the amount of dependencies, and not added any new?

[nimmolo]

@igorkasyanchuk That's right, no new dependencies.
But see answer to your question above, sorry.

[igorkasyanchuk]

@nimmolo could you please check this PR again, sorry long time, but maybe it still can be finished

[nimmolo]

Thanks Igor, I will check it next week. I hope you are doing ok and safe as possible.

…

On May 12, 2023, at 2:53 AM, Igor Kasyanchuk ***@***.***> wrote: @nimmolo <https://github.com/nimmolo> could you please check this PR again, sorry long time, but maybe it still can be finished — Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO3TPZJKTOZXT4S6FOJZR3XFYCBDANCNFSM5XPDRFBA>. You are receiving this because you were mentioned.