-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the castle reinforcement logic for AI (implement the long-standing TODO comment) #9283
Draft
oleg-derevenetz
wants to merge
8
commits into
ihhub:master
Choose a base branch
from
oleg-derevenetz:ai-castle-troops-hiring-improvement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve the castle reinforcement logic for AI (implement the long-standing TODO comment) #9283
oleg-derevenetz
wants to merge
8
commits into
ihhub:master
from
oleg-derevenetz:ai-castle-troops-hiring-improvement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oleg-derevenetz
commented
Nov 18, 2024
•
edited
Loading
edited
- The logic of castle reinforcement has been streamlined in the sense that just one AI-only method has been made instead of several different methods scattered across different classes (the same or better result is achieved in fewer actions);
- AI is now able to hire non-upgraded units if it does not have enough money for upgraded ones, just like a human player is able to do this in fheroes2 (but not in the original game!) - for instance, if AI does not have enough gold or sulfur for a Black Dragon, it can hire a Red one;
- AI now tries to make room for new units by upgrading and combining stacks of existing units (this logic was present before, but was more chaotic and irregular);
- AI is now able to merge same units from garrison to the guest hero's army if necessary to make room for new units.
…nding TODO comment)
oleg-derevenetz
added
improvement
New feature, request or improvement
AI
Artificial intelligence behaviour
labels
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.