Replace the clang-analyzer workflow with CodeChecker workflow #9293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeChecker is a front-end for multiple analyzers, but in our case it is intended to be used instead of LLVM
scan-buildto run the Clang Analyzer.Pros:
scan-buildhas an experimental support for CTU at best and is not recommended for this.Cons:
scan-buildanalysis (approximately x2 slower).Currently it found one issue in the LLVM internal header (seems legitimate BTW, but, naturally, there is nothing can be done with this, so I suppressed warnings for this header) and another issue in the implicit (compiler-generated) constructor (apparently copy or move constructor) for our own struct, which seems like a false positive (but probably it is related to that first issue in the LLVM header).
This PR is subject to discussion.