Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCAP: Replace latch with a synchronized() or lock #194

Open
jespersmith opened this issue Oct 31, 2024 · 0 comments
Open

MCAP: Replace latch with a synchronized() or lock #194

jespersmith opened this issue Oct 31, 2024 · 0 comments

Comments

@jespersmith
Copy link
Contributor

It seems that a countdown latch was used here instead of a simple lock. Adding a private final Object messagesLoadedLock = new Object(); and using synchronized(messagesLoadedLock) {} instead would avoid random nullptrexceptions due race conditions.

Same for chunckLoadedLatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant