-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm support for Python 3.13 and drop 3.8 #544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
=======================================
- Coverage 98.9% 98.9% -0.1%
=======================================
Files 44 44
Lines 4819 4790 -29
=======================================
- Hits 4769 4740 -29
Misses 50 50
|
b30e7c5
to
d0d42bf
Compare
- Add Python 3.13 - Drop Python 3.8
Python ≥3.9 feature.
be9bb90
to
0d3ad85
Compare
There doesn't appear to be any upstream response in the last 2+ months. One possibility is we switch away from this to an alternative that seems to be maintained. Alternatives I'm aware of include:
IIRC pretenders is also a source of flakiness, so a switch could side-step those issues. |
Okay, that was pretty easily done and the tests where it was used are simplified. |
Thanks, great news! Especially since the one failed test just failed due to a segfault, so this PR might be complete :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the last test passes :)
ixmp/tests/test_access.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much cleaner, thanks :)
Import of these from `typing` is deprecated from Python 3.9.
- Simpliy test_access.py, fixtures, and data. - Update [tests] dependencies in pyproject.toml - Update mypy config and pre-commit environment
Python 3.13 will be released 2024-10-01. This PR is to:
ixmp
is compatible with the new version. This includes the existence of compatible releases of upstream dependencies. If those releases are not immediately available, the PR can aid to monitor and track upstream issues:Question about maintenance / breaking with bottle v0.13 pretenders/pretenders#153list[str]
instead offrom typing import List
/List[str]
.from collections.abc import Sequence
et al instead of deprecatedfrom typing import Sequence
.These changes would then be on
main
and ready for the next release at any time.How to review
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/A