Add replace() and overlay() functions
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bottom | ||
| } | ||
| #[doc=generate_mut_doc_comment!("replace")] | ||
| pub fn replace_mut<P>(bottom: &mut Image<P>, top: &Image<P>, x: u32, y: u32) |
There was a problem hiding this comment.
Isn’t this just https://docs.rs/image/latest/image/trait.GenericImage.html#method.copy_from with a different name?
There was a problem hiding this comment.
I guess the error type on the GenericImage function is a bit clunky.
There was a problem hiding this comment.
I didn't see copy_from(), I think the functions are similar but being based on GenericImage may also have performance issues as we've found previously.
Also technically it is an image processing operation so belongs here more than in image but I don't feel too strongly about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two more functions migrated and re-implemented for image-rs/image#2238