Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback mechanism for GUI mode #301

Merged
merged 12 commits into from
Dec 3, 2024
Merged

Add callback mechanism for GUI mode #301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fec5cee
In GUI mode, stash ImageJ gateway in a global var
ctrueden Nov 16, 2022
bd2e4d3
Make rai_lock property private
ctrueden Jan 30, 2023
f38b200
Add when_imagej_starts callback mechanism
ctrueden Jan 31, 2023
29c2f9e
Simplify name of ImageJ2 gateway fixture
elevans Jan 23, 2024
ccb0e81
Add a simple test of when_imagej_starts callback
ctrueden Mar 13, 2023
221da1e
Create gateway, run callbacks in same function
gselzer May 25, 2023
3bae68b
Add docs section on how to use when_imagej_starts
elevans May 24, 2024
735304b
Add check to determine if current thread is main
elevans Jul 12, 2024
7667a09
Use descriptive attribute name for callback test
elevans Jul 15, 2024
972592d
Improve macOS pthread detection exception handling
elevans Jul 19, 2024
b2ce4cb
Use None as the getattr default, not True
elevans Oct 14, 2024
45c1448
Improve gui mode gateway clean up
elevans Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ def ij(request):
legacy = request.config.getoption("--legacy")
headless = request.config.getoption("--headless")

imagej.when_imagej_starts(
lambda ij: setattr(ij, "_when_imagej_starts_result", "success")
)
imagej.when_imagej_starts(lambda ij: setattr(ij, "_testing", True))

mode = "headless" if headless else "interactive"
ij = imagej.init(ij_dir, mode=mode, add_legacy=legacy)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ def test_when_imagej_starts(ij):
when_imagej_starts, which injects a small piece of data into the gateway
object. We check for that data here to make sure the callback happened.
"""
assert "success" == getattr(ij, "_when_imagej_starts_result", None)
gselzer marked this conversation as resolved.
Show resolved Hide resolved
assert True is getattr(ij, "_testing", True)
elevans marked this conversation as resolved.
Show resolved Hide resolved