shovel-config-ts: allow filter_arg to take empty string #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #277, a feature was introduced which made empty string values
""
infilter_arg
correspond tonull
when decoded. This change was not reflected in the TypeScript types for the shovel-config-ts config generator; this PR changes the types to allowfilter_arg
to take an empty string value.When testing my shovel config with the updated types in this PR, I was successfully able to add
""
to afilter_arg
without type errors.Something to consider — in the docs, it says:
Should the type actually be expanded to
(Hex | string)[]
here, or even juststring[]
?