-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gltf] Add glTF2 loader and pbr renderer #270
Draft
IAmNotHanni
wants to merge
127
commits into
main
Choose a base branch
from
hanni/gltf_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
added
the
cat:enhancement
enhancement/requested feature/update of existing features
label
Dec 7, 2020
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
December 9, 2020 21:00
edd0888
to
c4e764d
Compare
IAmNotHanni
changed the title
[gltf] Added basic glTF2 loader wrapper, work in progress!
[gltf] Added basic glTF2 loader wrapper
Dec 17, 2020
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
December 26, 2020 23:15
216b4d5
to
67e2160
Compare
IAmNotHanni
changed the title
[gltf] Added basic glTF2 loader wrapper
Basic glTF2 loader (no textures, animations or pbr yet)
Jan 4, 2021
IAmNotHanni
changed the title
Basic glTF2 loader (no textures, animations or pbr yet)
Basic glTF2 loader
May 10, 2021
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
May 10, 2021 13:36
5e6da6b
to
3295544
Compare
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
May 23, 2021 10:46
8ee8ffc
to
746425f
Compare
|
|
|
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
July 23, 2021 19:05
a1791fe
to
36c6490
Compare
|
IAmNotHanni
changed the title
[glTF2] Add basic glTF2 loader
[gltf] Add basic glTF2 loader
Jul 24, 2021
IAmNotHanni
commented
Jul 25, 2021
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
July 28, 2021 18:57
1147fa9
to
16fc351
Compare
|
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
July 30, 2021 19:49
6e69bfe
to
637f168
Compare
|
IAmNotHanni
force-pushed
the
hanni/gltf_support
branch
from
July 30, 2021 19:51
637f168
to
af0efbe
Compare
IAmNotHanni
changed the title
[gltf] Add basic glTF2 loader
[gltf] Add basic glTF2 loader and renderer
Aug 7, 2021
IAmNotHanni
added
org:on hold
on hold, until ...
and removed
prio:high
This has high priority.
labels
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:enhancement
enhancement/requested feature/update of existing features
org:on hold
on hold, until ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
Closes #268
Closes #429
Let there be glTF2 models
Work in progress!
I am adapting the glTF2 loader from Sascha Willem's sample repository. This work will not include model animations, physically based rendering or other components of glTF2 we're not supporting yet.
TODO
Sorting this massive PR
I will have to make smaller pull requests out of this one, otherwise it's too big.
Here is a list of things I changed:
ShaderLoader
wrapper and don't load shaders through TOML fileDescriptorPool
wrapperOffscreenFramebuffer
(required for cubemaps)