Fix attachEvent type error (#1661)

* Add specificity to fix a type error with addEventListener * addEventListener won't accept SemiSyntheticEvent due to extra helper methods, so we need to mark them as optional. * Fix linting error
infernojs · Jan 20, 2024 · 35ce542 · 35ce542
1 parent ca227a5
commit 35ce542
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/packages/inferno/src/DOM/events/delegation.ts b/packages/inferno/src/DOM/events/delegation.ts
@@ -185,8 +185,6 @@ function attachEventToDocument(
   name: string,
 ): (event: SemiSyntheticEvent<any>) => void {
   const attachedEvent = rootEvent(name);
-  // @ts-expect-error TODO: FIXME
   document.addEventListener(normalizeEventName(name), attachedEvent);
-
   return attachedEvent;
 }
diff --git a/packages/inferno/src/DOM/utils/common.ts b/packages/inferno/src/DOM/utils/common.ts
@@ -33,7 +33,7 @@ if (process.env.NODE_ENV !== 'production') {
   Object.freeze(EMPTY_OBJ);
 }
 
-export function normalizeEventName(name): string {
+export function normalizeEventName(name): keyof DocumentEventMap {
   return name.substring(2).toLowerCase();
 }
 

diff --git a/packages/inferno/src/core/types.ts b/packages/inferno/src/core/types.ts
@@ -79,8 +79,8 @@ export interface SemiSyntheticEvent<T> extends Event {
    * A reference to the element on which the event listener is registered.
    */
   currentTarget: EventTarget & T;
-  isDefaultPrevented: () => boolean;
-  isPropagationStopped: () => boolean;
+  isDefaultPrevented?: () => boolean;
+  isPropagationStopped?: () => boolean;
 }
 
 export type ClipboardEvent<T> = SemiSyntheticEvent<T> & NativeClipboardEvent;