Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed integration tests, bumped test projects up to .NET 6 #169

Closed
wants to merge 6 commits into from

Conversation

Sarsoo
Copy link
Contributor

@Sarsoo Sarsoo commented Dec 3, 2021

Fixed the integration tests and tested the other projects. Will follow this by repushing the #167 to retest

@rikkit
Copy link
Member

rikkit commented Dec 6, 2021

Hey @Sarsoo . changes look fine, thanks!. But I need to figure out why checks aren't running on this branch. Any ideas?

@Sarsoo
Copy link
Contributor Author

Sarsoo commented Dec 6, 2021

That's odd, I had assumed it was a security thing because I changed the actions. When I Google it, branch protection rules seem to keep coming up, community thread, docs

@rikkit
Copy link
Member

rikkit commented Dec 6, 2021

Have looked a bit into it, I think you may need to go to your fork of this repo and enable actions on it. Then you may need to push again to this branch to trigger the action... 🤔

@Sarsoo
Copy link
Contributor Author

Sarsoo commented Dec 7, 2021

I have actions enabled on my fork. On checking, however I did notice this setting

image

With a link to this bit of the docs which suggests that first time collaborators need approval. I can try pushing a dummy commit to see if it'll get it moving, presumably there's no button to approve the actions on the PR from your side?

@rikkit
Copy link
Member

rikkit commented Dec 13, 2021

This is what I see

image

Yeah I was wondering about the Actions config. The workflow is only set to run on push. I'm not sure what that should be changed to in order to run when a PR is opened from a forked repo. Can you try pushing that dummy commit?

Cheers

@Sarsoo
Copy link
Contributor Author

Sarsoo commented Dec 20, 2022

Coming back to this, I was hoping to see if we could move this forward. The blocker currently is the CI not running so I'm going to close this PR and open a new one to see if that can jump start it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants