-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed integration tests, bumped test projects up to .NET 6 #169
Conversation
added more nulled properties for those that can be altered on the API closes inflatablefriends#146
Hey @Sarsoo . changes look fine, thanks!. But I need to figure out why checks aren't running on this branch. Any ideas? |
That's odd, I had assumed it was a security thing because I changed the actions. When I Google it, branch protection rules seem to keep coming up, community thread, docs |
Have looked a bit into it, I think you may need to go to your fork of this repo and enable actions on it. Then you may need to push again to this branch to trigger the action... 🤔 |
I have actions enabled on my fork. On checking, however I did notice this setting With a link to this bit of the docs which suggests that first time collaborators need approval. I can try pushing a dummy commit to see if it'll get it moving, presumably there's no button to approve the actions on the PR from your side? |
Coming back to this, I was hoping to see if we could move this forward. The blocker currently is the CI not running so I'm going to close this PR and open a new one to see if that can jump start it |
Fixed the integration tests and tested the other projects. Will follow this by repushing the #167 to retest