Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GetTop commands from the Tag Api #176

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

eivanmariscal
Copy link

@eivanmariscal eivanmariscal commented Oct 5, 2023

Lastfm's documentation is off for these endpoints:

  • tag.getTopAlbums
  • tag.getTopTags

Documentation says that it should return a "topalbums" and "toptracks" object respectively but it's actually returning "albums" and "tracks".

This is related to issue #172 and this PR fixes that.

There was another bug in the tag.getTopTags command.
For this endpoint Lastfm doesn't return an URL object and this was throwig a NullReferenceException in the LastTag constructor. I added an overloaded constructor to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant