Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.sql): Enable the use of krb5 with mssql driver #15196

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 19, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15194

@telegraf-tiger telegraf-tiger bot added area/sql fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Apr 19, 2024
@powersj powersj self-assigned this Apr 19, 2024
@vin-ediezca
Copy link

@powersj linux_amd64.tar.gz image does not have sh or bash shells. I have to install some KRB5 dependencies first to test. do you have an artifact that has any of two?

@vin-ediezca
Copy link

@powersj linux_amd64.tar.gz image does not have sh or bash shells. I have to install some KRB5 dependencies first to test. do you have an artifact that has any of two?

Hi @powersj, Nvm my comment. I used amd64.deb instead. So far no errors on my local. I'll continue testing on our staging. Thanks!

@vin-ediezca
Copy link

Test passed @powersj. Thank you so much!

image

@powersj
Copy link
Contributor Author

powersj commented Apr 22, 2024

Thanks for confirming!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 22, 2024
@powersj powersj assigned DStrand1 and srebhan and unassigned powersj Apr 22, 2024
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small comment

go.mod Outdated Show resolved Hide resolved
@DStrand1 DStrand1 removed their assignment Apr 22, 2024
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we please also add this to the inputs.sql plugin in a separate PR!?!?

@srebhan srebhan merged commit 3138f84 into influxdata:master Apr 22, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 22, 2024
powersj added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include 'github.com/microsoft/go-mssqldb/integratedauth/krb5' package to outputs/sql/sql.go
4 participants