feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] #1016

tommayeliog · 2024-04-03T10:03:46Z

Checklist

JIRA - LW-5104, LW-10213
Proper tests implemented
Screenshots added.

Proposed solution

But ADA button added for Tokens page on the side bar (or under portfolio ballance, when no sidebar visible).
Hidden behind a feature flag USE_BANXA_TOPUP
If user agrees T&C and click "Continue" a new Tab opens with Banxa url.

PostHog actions added - LW-10213

Testing

For testing please change locally USE_BANXA_TOPUP=true

Screenshots

github-actions · 2024-04-03T10:27:06Z

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for a356d56e

	passed	failed	skipped	flaky	total	result
Total	30	0	0	0	30	✅

coveralls · 2024-04-03T10:35:47Z

coverage: 50.615% (+0.06%) from 50.56%
when pulling 348f1bc on feat/LW-5104-foor-buy-ada-button-modal
into 7071759 on main.

...browser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWalletButton.tsx

vetalcore · 2024-04-03T12:23:08Z

...owser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWallet.module.scss

+  height: 20px;
+}
+.badgeCaption {
+  color: var(--White, #FFF);  


could you please use proper color from _light/_dark.scss

Thanks @vetalcore I've change it to --color-white. This color will always be white regardless of theme because it's on specific background

apps/browser-extension-wallet/src/lib/translations/en.json

...owser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWallet.module.scss

...browser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWalletButton.tsx

przemyslaw-wlodek · 2024-04-03T12:43:50Z

...browser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWalletButton.tsx

+import { useTranslation } from 'react-i18next';
+import { BANXA_URL } from './config';
+
+export const TopUpWalletButton = (): React.ReactElement => {


Is it a button? Maybe we could leave TopUpWallet as a name because it's a feature with a button and dialog. You can come up with a better name ofc 😄

On the other hand I'd probably leave the button/dialog separately and integrate the logic in some sort of TopUpWalletCardContainer.

Thanks @przemyslaw-wlodek, yes, it's a button and a modal. It's not stated on the JIRA ticket but maybe at some point a new requirement will be added for the modal to be visible just once. Then Button will be much more relevant. TBO I don't know - maybe TopUpWalletButtonConfirmation?

I'd consider TopUpWallet then 😃 WDYT?

Thanks @przemyslaw-wlodek, I'm not 100% sure :) but it just because the feature has been named with the same name (TopUpWallet), and this "button + modal" is just one of the components, however I'm happy to rename it.

apps/browser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWalletCard.tsx

...browser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWalletDialog.tsx

apps/browser-extension-wallet/.env.defaults

pczeglik-iohk · 2024-04-03T20:37:14Z

@tommayeliog when you will have this feature ready to be merge, please remember to put JIRA ticket ID like LW-xxxx into the commit message. This helps to identify JIRA task by the commit message. You can check commit from main to get some inspiration ;) https://github.com/input-output-hk/lace/commits/main/

sonarcloud · 2024-04-04T12:28:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

przemyslaw-wlodek

I've left 1 minor comment about naming. Thank you @tommayeliog! GJ 🚀 Feel free to proceed when you resolve other comments.

…solution

...owser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWallet.module.scss

…s/TopUpWallet/TopUpWallet.module.scss Co-authored-by: Michael Chappell <[email protected]> Signed-off-by: Tom Mayel <[email protected]>

sonarcloud · 2024-05-20T15:14:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tommayeliog added 3 commits April 2, 2024 13:49

feat(extension): add buy ADA button and modal (WIP)

d6045aa

feat(extension): add buy ADA button and modal - scrollbar

6f67288

feat(extension): add buy ADA button and modal .env vars

348f1bc

tommayeliog requested review from a team as code owners April 3, 2024 10:03

tommayeliog requested review from mchappell, vetalcore and przemyslaw-wlodek April 3, 2024 10:04

vetalcore requested changes Apr 3, 2024

View reviewed changes

przemyslaw-wlodek requested changes Apr 3, 2024

View reviewed changes

pczeglik-iohk reviewed Apr 3, 2024

View reviewed changes

apps/browser-extension-wallet/.env.defaults Outdated Show resolved Hide resolved

tommayeliog and others added 2 commits April 4, 2024 10:49

feat(extension): buy ADA Banxa - fix PR comments

709be6f

Merge branch 'main' into feat/LW-5104-foor-buy-ada-button-modal

c3f1bc7

przemyslaw-wlodek approved these changes Apr 4, 2024

View reviewed changes

tommayeliog and others added 4 commits April 5, 2024 12:48

feat(extension): add PostHog events for Topup buy ADA

24cd31f

Merge branch 'main' into feat/LW-5104-foor-buy-ada-button-modal

1b9d076

fix(extension): remove unnecessary PostHog action

02f5b6d

Merge branch 'main' into feat/LW-5104-foor-buy-ada-button-modal

ff1355d

tommayeliog changed the title ~~feat(extension) add FOOR buy ADA button to Banxa~~ feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] Apr 8, 2024

refactor(extension): rename component for TopUpWallet

480dd6f

vetalcore approved these changes Apr 8, 2024

View reviewed changes

tommayeliog added 5 commits May 9, 2024 09:47

Merge branch 'main' into feat/LW-5104-foor-buy-ada-button-modal

e481499

feat(extension): foor buy ada via Banxa

7e88172

feat(extension): fix darkmode colour

0f4a8e2

feat(extension): fixing UI for Buy ADA card

7d98bf6

feat(extension): remove Buy ADA card from popup sidebar on smaller re…

1de8843

…solution

tommayeliog added 4 commits May 15, 2024 13:52

feat(extension): show buy ADA only on Mainnet

f217d20

feat(extension): by Ada Dialog - set default button Continue

38da05f

refactor(extension): fix test for AssetsPortfolio

1749dd7

Merge branch 'main' into feat/LW-5104-foor-buy-ada-button-modal

40145ee

tommayeliog removed the request for review from mchappell May 20, 2024 10:33

fix(ui): fix storybook call to action button

e314271

tommayeliog requested a review from mchappell May 20, 2024 11:59

mchappell approved these changes May 20, 2024

View reviewed changes

...owser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWallet.module.scss Outdated Show resolved Hide resolved

...owser-extension-wallet/src/views/browser-view/components/TopUpWallet/TopUpWallet.module.scss Outdated Show resolved Hide resolved

vetalcore approved these changes May 20, 2024

View reviewed changes

tommayeliog and others added 2 commits May 20, 2024 16:12

Update apps/browser-extension-wallet/src/views/browser-view/component…

6c0d6d9

…s/TopUpWallet/TopUpWallet.module.scss Co-authored-by: Michael Chappell <[email protected]> Signed-off-by: Tom Mayel <[email protected]>

Update apps/browser-extension-wallet/src/views/browser-view/component…

a356d56

…s/TopUpWallet/TopUpWallet.module.scss Co-authored-by: Michael Chappell <[email protected]> Signed-off-by: Tom Mayel <[email protected]>

tommayeliog merged commit 5e0a649 into main May 21, 2024
12 checks passed

tommayeliog deleted the feat/LW-5104-foor-buy-ada-button-modal branch May 21, 2024 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] #1016

feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] #1016

tommayeliog commented Apr 3, 2024 •

edited by vetalcore

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

coveralls commented Apr 3, 2024

vetalcore Apr 3, 2024

tommayeliog Apr 4, 2024

przemyslaw-wlodek Apr 3, 2024

tommayeliog Apr 4, 2024

przemyslaw-wlodek Apr 4, 2024

tommayeliog Apr 8, 2024

pczeglik-iohk commented Apr 3, 2024

sonarcloud bot commented Apr 4, 2024

przemyslaw-wlodek left a comment

sonarcloud bot commented May 20, 2024

feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] #1016

feat(extension) add FOOR buy ADA button to Banxa [LW-5104],[LW-10213] #1016

Conversation

tommayeliog commented Apr 3, 2024 • edited by vetalcore Loading

Checklist

Proposed solution

Testing

Screenshots

github-actions bot commented Apr 3, 2024 • edited Loading

Allure Report

coveralls commented Apr 3, 2024

vetalcore Apr 3, 2024

Choose a reason for hiding this comment

tommayeliog Apr 4, 2024

Choose a reason for hiding this comment

przemyslaw-wlodek Apr 3, 2024

Choose a reason for hiding this comment

tommayeliog Apr 4, 2024

Choose a reason for hiding this comment

przemyslaw-wlodek Apr 4, 2024

Choose a reason for hiding this comment

tommayeliog Apr 8, 2024

Choose a reason for hiding this comment

pczeglik-iohk commented Apr 3, 2024

sonarcloud bot commented Apr 4, 2024

Quality Gate passed

przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 20, 2024

Quality Gate passed

tommayeliog commented Apr 3, 2024 •

edited by vetalcore

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading