fix: remove unnatural Ada rounding #1442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ❌ test report for 6eecf095
|
rhyslbw
force-pushed
the
fix/ada-decimal-precisiom
branch
from
5162df9
to
61c99c7
Compare
rhyslbw
force-pushed
the
fix/ada-decimal-precisiom
branch
from
61c99c7
to
ef66f74
Compare
|
At the moment it seems that UI components will start displaying all 6 decimals if present. |
rhyslbw
force-pushed
the
fix/ada-decimal-precisiom
branch
2 times, most recently
from
876b6a3
to
1c0fd20
Compare
- Ada has a 6 decimal point precision, but currently we're rounding to 2 - Decimals on the CoinId type is dropped to simplify the implementation, as Ada has a constant value and it's not used for any other currencies - Fixes some wonky logic that was working due to the common rounding to 2 decimal points
rhyslbw
force-pushed
the
fix/ada-decimal-precisiom
branch
from
1c0fd20
to
6eecf09
Compare
|
DominikGuzei
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ada naturally supports 6 decimal points, and we should be supporting this precision