Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-11830]: handle not delegated stake keys scenarios in send flow #1543

Merged

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Nov 19, 2024

Checklist

  • JIRA - LW-11830
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-11-27 at 15 19 35

@vetalcore vetalcore self-assigned this Nov 19, 2024
@vetalcore vetalcore requested a review from a team as a code owner November 19, 2024 11:26
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Nov 19, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 906babc6

passed failed skipped flaky total result
Total 32 0 4 0 36

@vetalcore vetalcore force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from 18975ed to dba4245 Compare November 26, 2024 15:22
@vetalcore vetalcore force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from 759e9d0 to 43bcc48 Compare November 27, 2024 13:22
@vetalcore vetalcore force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from 43bcc48 to fce46a3 Compare November 28, 2024 13:14
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @vetalcore !

@vetalcore vetalcore force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from fce46a3 to 0fb8a23 Compare December 4, 2024 11:41
@vetalcore vetalcore force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from 0fb8a23 to b0510d1 Compare December 6, 2024 23:11
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch 2 times, most recently from 153c69d to da40c83 Compare December 11, 2024 00:49
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch from da40c83 to 37ff48e Compare December 11, 2024 08:55
@przemyslaw-wlodek przemyslaw-wlodek enabled auto-merge (squash) December 11, 2024 09:03
Copy link

sonarcloud bot commented Dec 11, 2024

@przemyslaw-wlodek przemyslaw-wlodek merged commit 6806594 into main Dec 11, 2024
31 of 32 checks passed
@przemyslaw-wlodek przemyslaw-wlodek deleted the feat/lw-11830-handle-not-delegated-stake-keys-send-flow branch December 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants