Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[429]: Unicorn remove the gem declaration if Instana disabled #434

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

arjun-rajappa
Copy link
Contributor

unicorn worker was trying to delete the Instana constant twice. Hence adding check defined?

…ice. Hence adding check defined?

Signed-off-by: Arjun Rajappa <[email protected]>
@arjun-rajappa arjun-rajappa requested a review from a team November 13, 2024 09:08
@arjun-rajappa arjun-rajappa self-assigned this Nov 13, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@arjun-rajappa arjun-rajappa merged commit 0ab1a3f into master Nov 13, 2024
247 of 248 checks passed
@arjun-rajappa arjun-rajappa deleted the use-instana-disable-to-stop-after-fork-hook branch November 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants