Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-5837 remove uninstall logic from rhoam #3375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

austincunningham
Copy link
Member

@austincunningham austincunningham commented Sep 22, 2023

Issue link

MGDAPI-5837

What

remove uninstall logic from rhoam this will now be handled by the addon operator

Verification steps

  • Install via the addon via the ocm ui
  • patch the csv with an operator image built of this branch
  • wait for the install to finish
  • uninstall via the ocm ui the uninstall should complete

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from austincunningham. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.79%. Comparing base (121bdd1) to head (2efe8ba).
Report is 127 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage   48.67%   48.79%   +0.12%     
==========================================
  Files          98       98              
  Lines       14106    14071      -35     
==========================================
  Hits         6866     6866              
+ Misses       6499     6464      -35     
  Partials      741      741              
Files Coverage Δ
controllers/rhmi/rhmi_controller.go 5.38% <ø> (+0.02%) ⬆️
pkg/addon/parameters.go 95.91% <ø> (ø)
pkg/addon/uninstall.go 0.00% <ø> (ø)

@austincunningham
Copy link
Member Author

/hold

@austincunningham
Copy link
Member Author

holding due to the functionality not being available in the addon operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant