Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

Support debian 9 #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support debian 9 #107

wants to merge 2 commits into from

Conversation

devimc
Copy link

@devimc devimc commented Jan 29, 2019

Julio Montes added 2 commits January 29, 2019 12:44
Some distros, like debian 9, requires a VGA card to start without issues.
Current supported distros won't be affected by this change.

Signed-off-by: Julio Montes <[email protected]>
Add debian 9 workload

Signed-off-by: Julio Montes <[email protected]>
Copy link
Contributor

@markdryan markdryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like -vga virtio is a very new feature that might not have widespread adoption. It's certainly not supported by the version of qemu used in the CI builds. What actually happens when you do this on a host/guest that support it. Do you see a window?

The only way we could merge something like this would be to allow the user to override the display and vga settings in the workload specifications. These user supplied values would then get passed down to this code. Actually, this might be a nice way of debugging things.

@devimc
Copy link
Author

devimc commented Jan 30, 2019

What actually happens when you do this on a host/guest that support it. Do you see a window?

No,

The only way we could merge something like this would be to allow the user to override the display and vga settings in the workload specifications. These user supplied values would then get passed down to this code. Actually, this might be a nice way of debugging things.

sounds good, let me see what I can do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants