bump(postcss): update postcss version to 8.0.0 #37
Conversation
|
You're probably going to have to change our node version to |
There was a problem hiding this comment.
Stepped through the changes while looking at the migration guide. Great work so far! There were a couple of improvements in the migration guide that we should probably update, but otherwise it looks great.
|
|
||
| root.walkRules(rule => { | ||
| const themedDeclarations: postcss.Declaration[] = []; | ||
| root.walkRules(walkRule => { |
There was a problem hiding this comment.
Looking at the migration guide, I think we should remove the root.walk and use Rules api instead.
| @@ -458,30 +464,30 @@ const modernTheme = ( | |||
| mergedSingleThemeConfig && hasDarkMode(mergedSingleThemeConfig); | |||
|
|
|||
| // 1. Walk each declaration and replace theme vars with CSS vars | |||
| root.walkRules(rule => { | |||
| rule.selector = replaceThemeRoot(rule.selector); | |||
| root.walkRules(walkRule => { | |||
There was a problem hiding this comment.
Same comment about switching walkRules to Rules if possible.
| @@ -622,4 +628,4 @@ const themeFile = (options: PostcssThemeOptions = {}) => ( | |||
| } | |||
| }; | |||
|
|
|||
| export default postcss.plugin('postcss-themed', themeFile); | |||
| export default themeFile; | |||
There was a problem hiding this comment.
Looking at the migration guide, I think there might be a couple of recommended attributes we should include like postCSSPlugin and Once.
|
Hey @nehapatwardhan6490, I just merged #35 which refactored some of the code into different files. It's going to cause some conflicts here--really sorry about that. Let me know if you need any help merging the changes. |
|
@nehapatwardhan6490 do you need any help with this? |
|
Hey, sorry didn't get a chance to look in to this. WI check it out in next few days and get back to you |
What Changed
Upgraded version of postcss to 8.0.0
Why
It's the latest version and gives improved performance
Todo:
yarn all-contributors add [name] [type]) see https://github.com/all-contributors/all-contributors/blob/master/docs/cli/usage.md