Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not play nicely with AWS.jl #27

Open
kleinschmidt opened this issue May 25, 2021 · 2 comments
Open

does not play nicely with AWS.jl #27

kleinschmidt opened this issue May 25, 2021 · 2 comments

Comments

@kleinschmidt
Copy link

This package uses AWSCore.jl which does not interoperate with AWS.jl, the config struct in particular:

julia> ?CloudWatchLogStream
CloudWatchLogStream(config::AWSConfig, log_group_name, log_stream_name)

Create a reference to a CloudWatch Log Stream on AWS with the log group name and
log stream name. This constructor will automatically fetch the latest [sequence
token](https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutLogEvents.html#CWL-PutLogEvents-request-sequenceToken) for the stream.

julia> stream = CloudWatchLogStream(AWS.global_aws_config(), "my-group", "my-stream")
MethodError: no method matching CloudWatchLogStream(::AWSConfig, ::String, ::String)
Closest candidates are:
  CloudWatchLogStream(::Any, ::Any, ::Any, ::Any) at /home/ubuntu/.julia/packages/CloudWatchLogs/W1Ltg/src/stream.jl:22
  CloudWatchLogStream(::Dict{Symbol, Any}, ::String, ::String, ::Ref{Union{Nothing, String}}) at /home/ubuntu/.julia/packages/CloudWatchLogs/W1Ltg/src/stream.jl:22
  CloudWatchLogStream(::Dict{Symbol, Any}, ::AbstractString, ::AbstractString) at /home/ubuntu/.julia/packages/CloudWatchLogs/W1Ltg/src/stream.jl:36

I think the solution to this is to "just" upgrade to AWS.jl but I'm not sure how heavy a lift that would be.

@iamed2
Copy link
Member

iamed2 commented May 25, 2021

cc @mattBrzezinski

@mattBrzezinski
Copy link
Member

Ah yes, forgot about this package existing. Updating it to use AWS.jl is really trivial:

  • Replace all usages of AWSCore with AWS
  • Use the higher-level function calls if we want, or just keep the lower-level ones as this already uses them
  • Version bump

My hands are full currently with work, but when I have some time I can make this a priority. If you'd like to attempt tackling the changes yourself I am available on the Julia Slack for any questions, comments, etc. or through GitHub for the code review process. Just feel free to tag me in anything. 😄

This was referenced May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants