Replace AWSCore with AWS.jl #28
Conversation
|
Is there no CI on this repo? |
|
Looks like #26 never got merged, I pinged Fernando around it. Should also move this into the JuliaCloud org too. |
There was a problem hiding this comment.
LGTM, just want to get #26 in before hand so we can test that the changes work.
|
@mattBrzezinski, it might be good to have you re-review if you get the time, since the refactoring to remove the internal function that mimics the old AWSCore API is a larger change introduced since your approval. |
There was a problem hiding this comment.
The changes LGTM! Thanks for simplified the test files too :)
Just need to get around to #26 before this will go in. It just seems to be a timing issue like almost all the AWS CI errors happen to be. Might just merge that in anyways.
|
Oh this is awkward... I don't remember how GitHub handles the introduction of CI workflows for merge requests that exist before those going in. I believe a rebase onto |
|
I rebased on master but it looks like running CI requires approval by someone with commit access. |
|
Sigh, needs another approval. Sorry 😬 |
No worries, kind of silly it needs to be done after I approved it once before, oh well. |
|
Hm. Seems something still isn't quite right. 🤔 |
|
Could this be failing because this doesn't have bors, so it's running without access to our secrets since this is a PR from a fork? |
|
@ararslan I've invited you as a collaborator with Write access so you could re-push this PR on the repo itself. |
|
Quite possibly! Thanks for the invite, I'll close this and reopen from a branch. |
This might be an issue w/ the high-level AWS functions. I'm looking into it now. |
Fixes #27.
Ping @mattBrzezinski for review. 🙂