Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: configure Flask-KVSession #222

Closed
wants to merge 1 commit into from
Closed

config: configure Flask-KVSession #222

wants to merge 1 commit into from

Conversation

diegodelemos
Copy link
Member

@diegodelemos diegodelemos force-pushed the ia-289/integrate-flask-kvsession-invenio branch from 1f897b4 to 2ad70d9 Compare May 11, 2020 11:35
diegodelemos
diegodelemos commented May 11, 2020
View reviewed changes
{{cookiecutter.project_shortname}}/{{cookiecutter.package_name}}/config.py
Comment on lines +96 to +97
SESSION_INTERFACE_FACTORY = \
'invenio_accounts.sessions:KVSessionInterfaceStoreAuthenticated'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially decided to be set by Invenio-Accounts but there is no guarantee that Invenio-Accounts will be loaded before Flask-KVSession-Invenio.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is Flask-KVSession-Initialised? I think there's potentially something if it's loaded before Invenio-Accounts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an extra check - it's because the variables are filtered out here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, wrong highlight - here

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 2ad70d9 on diegodelemos:ia-289/integrate-flask-kvsession-invenio into 18d5e90 on inveniosoftware:master.

@ppanero
Copy link
Member

ppanero commented May 13, 2020

Closing. More info in the EPIC inveniosoftware/invenio-accounts#320

@ppanero ppanero closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnielsen lnielsen lnielsen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global: fork or integrate Flask-KVSession
4 participants
@diegodelemos @coveralls @ppanero @lnielsen