Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft classes of object/opinionated layer #267

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Draft classes of object/opinionated layer #267

wants to merge 15 commits into from

Commits on Oct 29, 2022

  1. Create module interfaces.py 

      - Add interfaces.py to process responses into third-party library objects
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    68d51dd View commit details
    Browse the repository at this point in the history

  2. Use methods from interfaces.py in erddapy.py module

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e60e4e4 View commit details
    Browse the repository at this point in the history

  3. Remove iris typehint

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    b6a2086 View commit details
    Browse the repository at this point in the history

  4. Fixing kwargs propagation in interfaces module

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    ff2961e View commit details
    Browse the repository at this point in the history

  5. Fix timeout test 

      - Use existing dataset
  - Pass requests_kwargs to 'to_pandas' method
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    85f5233 View commit details
    Browse the repository at this point in the history

  6. Add PyCharm .idea/ dir to .gitignore

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e5aa1dc View commit details
    Browse the repository at this point in the history

  7. Drafting new classes 

      This commit introduces a rough draft of the classes to be introduced in the
  object/opinionated layer. For now, the subpackage containing them is named 'objects'
  but that may change in the future. For discussion, see ioos#228.

  - Add 'objects' subpackage with init module
  - Add 'objects.py' module with 5 new classes
    - Methods will be implemented in the following commits.
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    19e38d8 View commit details
    Browse the repository at this point in the history

  8. Add imports to package top-level init

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    101d1b0 View commit details
    Browse the repository at this point in the history

  9. Add __future__ import 

      The '|' operator for typing was introduced in Python 3.10. This import
  allows previous Python versions to work with this operator.
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    b33bd08 View commit details
    Browse the repository at this point in the history

  10. Simplify constructor method of ERDDAPServer 

    - code review

Co-authored-by: Alex Kerney <[email protected]>
    @vinisalazar @abkfenris
    vinisalazar and abkfenris committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    9345c93 View commit details
    Browse the repository at this point in the history

  11. Refactoring subpackage name 

      - Rename 'objects' to 'array_like' to avoid clobbering Python built-ins
  - Refactor imports
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    f5ab397 View commit details
    Browse the repository at this point in the history

  12. Split classes into modules 

      - Create connection.py, datasets.py, server.py
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    122c14d View commit details
    Browse the repository at this point in the history

  13. Remove array_like module 

      Replaced by connections, datasets, and server modules.
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    0782350 View commit details
    Browse the repository at this point in the history

  14. Fix imports in array_like module

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    3a918c4 View commit details
    Browse the repository at this point in the history

  15. Add annotations import 

      Add __future__.annotations import to modules 'datasets' and 'server'
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e8f9c11 View commit details
    Browse the repository at this point in the history