Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ERC20 token Incentive in gauge #10

Closed
wants to merge 6 commits into from
Closed

Conversation

ludete
Copy link
Contributor

@ludete ludete commented Jul 12, 2024

No description provided.

contracts/rewards/CustomReward.sol Show resolved Hide resolved
contracts/rewards/CustomReward.sol Show resolved Hide resolved
contracts/rewards/Incentive.sol Outdated Show resolved Hide resolved
contracts/interfaces/IReward.sol Outdated Show resolved Hide resolved
contracts/interfaces/IReward.sol Show resolved Hide resolved
contracts/Voter.sol Outdated Show resolved Hide resolved
contracts/interfaces/IReward.sol Outdated Show resolved Hide resolved
contracts/interfaces/IReward.sol Show resolved Hide resolved
contracts/Voter.sol Outdated Show resolved Hide resolved
ludete added 3 commits July 17, 2024 17:12
2. add incentive field and callback the  contract of incentive when deposit or withdraw
3. split  logic of the add reward token to new function.
4. delete unused code in IReward.sol;
5. delete logic of claimIncentive by proxy in voter
 delete unused code in IVoter.sol;
contracts/rewards/Incentive.sol Outdated Show resolved Hide resolved
contracts/rewards/Reward.sol Show resolved Hide resolved
@@ -153,6 +163,10 @@ abstract contract Reward is IReward, ERC2771Context, ReentrancyGuard {
return rewards.length;
}

function rewardTokens() external view returns (address[] memory) {
return rewards;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards may be too long to be returned

contracts/rewards/Reward.sol Show resolved Hide resolved
@ludete ludete closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants