fix: normalize catch-all listeners to loopback #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
reviewed
Nov 1, 2024
Comment on lines
+94
to
+98
| const address = (Array.isArray(config.Addresses[name]) | ||
| ? config.Addresses[name][0] | ||
| : config.Addresses[name] | ||
| : config.Addresses[name]) | ||
| .replace(/\/0\.0\.0\.0\//, '/127.0.0.1/') // fix for https://github.com/ipfs/ipfs-webui/issues/1821 | ||
| .replace(/\/::\//, '/::1/') |
There was a problem hiding this comment.
should we take this chance to more gracefully handle the array of addresses if it exists? do we always want the first one, or do we want the local one if one is found?
There was a problem hiding this comment.
in practice, virtually all users will have only one listener, but the field in Kubo can be either a string or list of strings, so I think its ok as-is (not worth extra time/code).
SgtPooki
approved these changes
Nov 7, 2024
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
## [4.4.0](v4.3.3...v4.4.0) (2024-11-07) CID `bafybeibkirkltohusogcco46jcw7khtgjf5nwphuvufjssr5pvhsuol5uy` --- ### Features * use [email protected] ([#2283](#2283)) ([437b8fe](437b8fe)), closes [#2259](#2259) ### Bug Fixes * normalize catch-all listeners to loopback ([#2287](#2287)) ([edf14c6](edf14c6)), closes [#1821](#1821) * remove iltorb dep, build for node v22.9.0 ([#2273](#2273)) ([9ba4559](9ba4559)) ### Trivial Changes * move enum.js to lib folder ([#2285](#2285)) ([682de0b](682de0b)) * pull new translations ([#2279](#2279)) ([8205d12](8205d12))
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1821