feat(libp2p): shared TCP listeners and AutoTLS.AutoWSS #10565
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ require ( | |
| github.com/jbenet/goprocess v0.1.4 | ||
| github.com/julienschmidt/httprouter v1.3.0 | ||
| github.com/libp2p/go-doh-resolver v0.4.0 | ||
| github.com/libp2p/go-libp2p v0.37.2 | ||
| github.com/libp2p/go-libp2p-http v0.5.0 | ||
| github.com/libp2p/go-libp2p-kad-dht v0.28.1 | ||
| github.com/libp2p/go-libp2p-kbucket v0.6.4 | ||
|
|
@@ -274,3 +274,5 @@ require ( | |
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| lukechampine.com/blake3 v1.3.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/libp2p/go-libp2p => github.com/libp2p/go-libp2p v0.37.1-0.20241202220543-9024f8e8c86e | ||
|
There was a problem hiding this comment. There seem to be a regression between 9b887ea (this PR) and 433444b (latest master) caused by TCP reuse logic in go-libp2p bumped here. I did How to reproduce
Here are docker images for repro convenience:
There was a problem hiding this comment. There was a problem hiding this comment. libp2p/go-libp2p#3080 seems to fix the CPU spin. Tested in 2adb2f1 – need to investigate why CI fails. There was a problem hiding this comment. I am debugging sharness with There was a problem hiding this comment. Getting bizzare. Tests with the same go-libp2p and boxo version pass in #10631. The only - github.com/ipshipyard/p2p-forge v0.1.0
+ github.com/ipshipyard/p2p-forge v0.2.0other than that, we don't change anything in default config other than enabling shared tcp. There was a problem hiding this comment. Still looking for the cause, but I was able to reproduce locally by using the same settings as CI: $ export TEST_DOCKER=1
$ export TEST_PLUGIN=0
$ export TEST_FUSE=0
$ export TEST_VERBOSE=1
$ export TEST_JUNIT=1
$ export TEST_EXPENSIVE=1
$ export IPFS_CHECK_RCMGR_DEFAULTS=1
$ export CONTINUE_ON_S_FAILURE=1
$ time make -O -j 10 test_sharness coverage/sharness_tests.coverprofile test/sharness/test-results/sharness.xml
# [...]
ok 1717 - add a few entries to big_dir/ to retrigger sharding
expecting success:
kill -0 $IPFS_PID
ok 1718 - 'ipfs daemon' is still running
expecting success:
test_kill_repeat_10_sec $IPFS_PID
ok 1719 - 'ipfs daemon' can be killed
# passed all 1719 test(s)
1..1719
# hangs..It hanged for a few minutes and finished eventually, but took 3x longer than regular run (15m vs 5m). Looking at process tree spawned by Will resume tomorrow unless someone else has any idea. In the meantime, i've re-run https://github.com/ipfs/kubo/actions/runs/12420930073 to double-confirm disabling There was a problem hiding this comment. There was a problem hiding this comment. Ok, running sequentially (#10565 (comment)) found the problem:
I'll now confirm this is the only one failing, I'll also see if we can set timeout per test suite / unit, to avoid this debugging horror in the future. There was a problem hiding this comment. Good news, PNET was the only reason sharness failed. Disabled port sharing when PNET is enabled (bb87df3) and CI is green again: I'm going forward with Kubo 0.33.0-rc1. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got this to the state that is as close to go-libp2p release as possible, filling this here so I won't forget: