Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pickx.be : automatic API URL finding #2480

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pickx.be : automatic API URL finding #2480

wants to merge 2 commits into from

Conversation

BellezaEmporium
Copy link
Contributor

@BellezaEmporium BellezaEmporium commented Nov 26, 2024 •
edited
Loading

Don't ask me how i've found that.

@BellezaEmporium
Copy link
Contributor Author

BellezaEmporium commented Nov 26, 2024 •
edited
Loading

Tests have passed, grabber seems to work.
image
image

@BellezaEmporium
Copy link
Contributor Author

Summoning @davidclaeysquinones as he was keen into updating the URL all the time.

freearhey
freearhey requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@freearhey freearhey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a merge conflict when trying to check the branch.

@BellezaEmporium
Copy link
Contributor Author

Maybe due to the latest additions. I'll check

BellezaEmporium
BellezaEmporium commented Nov 27, 2024
View reviewed changes
Copy link
Contributor Author

@BellezaEmporium BellezaEmporium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freearhey freearhey freearhey requested changes

@PopeyeTheSai10r PopeyeTheSai10r Awaiting requested review from PopeyeTheSai10r

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BellezaEmporium @freearhey