Skip to content

Commit

Permalink
assign pep number. Fix build errors
Browse files Browse the repository at this point in the history
  • Loading branch information
iritkatriel committed Nov 15, 2024
1 parent 0450fe4 commit 8971a6f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ peps/pep-0760.rst @pablogsal @brettcannon
peps/pep-0761.rst @sethmlarson @hugovk
peps/pep-0762.rst @pablogsal @ambv @lysnikolaou @emilyemorehouse
peps/pep-0763.rst @dstufft
peps/pep-0765.rst @iritkatriel @ncoghlan
# ...
peps/pep-0777.rst @warsaw
# ...
Expand Down
12 changes: 6 additions & 6 deletions peps/pep-9999.rst → peps/pep-0765.rst
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PEP: 9999
PEP: 765
Title: Disallow return/break/continue that exit a finally block
Author: Irit Katriel <[email protected]>, Alyssa Coghlan <[email protected]>
Discussions-To: https://discuss.python.org/t/an-analysis-of-return-in-finally-in-the-wild/70633
Expand Down Expand Up @@ -50,15 +50,15 @@ and flake8-bugbear [4]_ flag them as a problem.
Rationale
=========

A recent analysis of real world code [5]_ shows that::
A recent analysis of real world code [5]_ shows that:

- These features are rare (2 per million LOC in the top 8000 PyPI
packages, 4 per million LOC in a random selection of packages).
This could be thanks to the linters that flag this pattern.
packages, 4 per million LOC in a random selection of packages).
This could be thanks to the linters that flag this pattern.
- Most of the usages are incorrect, and introduce unintended
exception-swallowing bugs.
exception-swallowing bugs.
- Code owners are typically receptive to fixing the bugs, and
find that easy to do.
find that easy to do.

This new data indicates that it would benefit Python's users if
Python itself moved them away from this harmful feature.
Expand Down

0 comments on commit 8971a6f

Please sign in to comment.