Skip to content

Commit

Permalink
more of MAL's review
Browse files Browse the repository at this point in the history
  • Loading branch information
iritkatriel committed Oct 30, 2023
1 parent 5bb87df commit abfd8a1
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions peps/pep-0733.rst
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,11 @@ Type Definition and Object Creation

The C API has functions that make it possible to create incomplete
or inconsistent Python objects, such as ``PyTuple_New`` and
``PyUnicode_New``. This causes problem when the object is tracked
``PyUnicode_New``. This causes problems when the object is tracked
by GC or its ``tp_traverse``/``tp_clear`` functions are called.
Such functions should be removed from the C API. Related functions,
such as ``PyTuple_SetItem`` which is used to modify a partially
initialized tuple, should also be removed (tuples are immutable
once fully initialized)
A related issue is with functions such as ``PyTuple_SetItem``
which is used to modify a partially initialized tuple (tuples
are immutable once fully initialized)
[`Issue 56 <https://github.com/capi-workgroup/problems/issues/56>`__].

We identified a few issues with type definition APIs. For legacy
Expand Down Expand Up @@ -617,7 +616,7 @@ are not included from ``Python.h``.
**Naming**

``PyLong`` and ``PyUnicode`` use names which no longer match the Python
types they represent (``int``/``str``). This can be fixed in a new API
types they represent (``int``/``str``). This could be fixed in a new API
[`Issue 14 <https://github.com/capi-workgroup/problems/issues/14>`__].

There are identifiers in the API which are lacking a ``Py``/``_Py``
Expand Down

0 comments on commit abfd8a1

Please sign in to comment.