Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ZMS-3253 ZMS-1891 ZMS-3415): Replicate frontend validation in the backend for the availability opening hours to improve data integrity and frontend validation messaging #685

Open
wants to merge 89 commits into
base: next
Choose a base branch
from
Open

fix(ZMS-3253 ZMS-1891 ZMS-3415): Replicate frontend validation in the backend for the availability opening hours to improve data integrity and frontend validation messaging #685

wants to merge 89 commits into from
+1,590 −568

Commits on Nov 12, 2024

  1. fix(ZMS-3253): validate and block adding conflicting openingtimes

    Tom Fink authored and Tom Fink committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    310f536 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fix(ZMS-3253): add backend validation for opening hours and improve f… 

    …orm error messaging
    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bbd32b1 View commit details
    Browse the repository at this point in the history

  2. fix(ZMS-3253): fix zmsentities unit test

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5543f36 View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-3253): fix zmsdb unit test

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    03bc86e View commit details
    Browse the repository at this point in the history

  4. fix(ZMS-3253): add logging to zmsapi tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ffcdb0a View commit details
    Browse the repository at this point in the history

  5. fix(ZMS-3253): fix one zmsapi unit test

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    47565c8 View commit details
    Browse the repository at this point in the history

  6. fix(ZMS-3253): try fix one zmsapi unit test

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3f8030e View commit details
    Browse the repository at this point in the history

  7. fix(ZMS-3253): try fix one zmsapi unit test

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f5e08ed View commit details
    Browse the repository at this point in the history

  8. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e4b36ea View commit details
    Browse the repository at this point in the history

  9. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e5f123c View commit details
    Browse the repository at this point in the history

  10. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9528271 View commit details
    Browse the repository at this point in the history

  11. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    770e847 View commit details
    Browse the repository at this point in the history

  12. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4a79605 View commit details
    Browse the repository at this point in the history

  13. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cdd0d8c View commit details
    Browse the repository at this point in the history

  14. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8a1aa79 View commit details
    Browse the repository at this point in the history

  15. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    09c10fb View commit details
    Browse the repository at this point in the history

  16. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    afd6d5d View commit details
    Browse the repository at this point in the history

  17. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ce5d795 View commit details
    Browse the repository at this point in the history

  18. Revert "fix(ZMS-3253): try fix some unit tests" 

    This reverts commit ce5d795.
    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    07f74c8 View commit details
    Browse the repository at this point in the history

  19. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    da65ff3 View commit details
    Browse the repository at this point in the history

  20. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    93b2820 View commit details
    Browse the repository at this point in the history

  21. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e0d41c4 View commit details
    Browse the repository at this point in the history

  22. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bde21f3 View commit details
    Browse the repository at this point in the history

  23. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0cd0ad1 View commit details
    Browse the repository at this point in the history

  24. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    29b7cff View commit details
    Browse the repository at this point in the history

  25. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9e11157 View commit details
    Browse the repository at this point in the history

  26. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c2df444 View commit details
    Browse the repository at this point in the history

  27. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5faea71 View commit details
    Browse the repository at this point in the history

  28. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4cd3618 View commit details
    Browse the repository at this point in the history

  29. fix(ZMS-3253): try fix some unit tests

    Tom Fink authored and Tom Fink committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4840338 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. fix(ZMS-3253): backend validation work in AvailabilityAdd

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c8262a0 View commit details
    Browse the repository at this point in the history

  2. fix(ZMS-3253): correct backend validation for timeoverlaps

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8281b0a View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-3253): fix a validation

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    390aba7 View commit details
    Browse the repository at this point in the history

  4. fix(ZMS-3253): try fixing a test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    78013ea View commit details
    Browse the repository at this point in the history

  5. fix(ZMS-3253): try fixing a test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8a07621 View commit details
    Browse the repository at this point in the history

  6. fix(ZMS-3253): try fixing a test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7892fe0 View commit details
    Browse the repository at this point in the history

  7. fix(ZMS-3253): try fixing a test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9522585 View commit details
    Browse the repository at this point in the history

  8. fix(ZMS-3253): try fixing availability not found test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d65ccb8 View commit details
    Browse the repository at this point in the history

  9. fix(ZMS-3253): try fixing availability mockdata for testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3fa84a1 View commit details
    Browse the repository at this point in the history

  10. fix(ZMS-3253): try fixing availability mockdata for testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    317d127 View commit details
    Browse the repository at this point in the history

  11. fix(ZMS-3253): try fixing availability mockdata for testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c02e4e3 View commit details
    Browse the repository at this point in the history

  12. fix(ZMS-3253): try fixing availability mockdata for testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c75e3c4 View commit details
    Browse the repository at this point in the history

  13. fix(ZMS-3253): try fixing availability mockdata for testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2b39546 View commit details
    Browse the repository at this point in the history

  14. fix(ZMS-3253): try fix missing scope testRendering

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    acb62ac View commit details
    Browse the repository at this point in the history

  15. fix(ZMS-3253): fix zmsadmin availabilities conflict test

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a16b2e4 View commit details
    Browse the repository at this point in the history

  16. fix(ZMS-3253): show availability opening hour conflicts in the future… 

    … not just for selectedDate
    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1bd40cb View commit details
    Browse the repository at this point in the history

  17. fix(ZMS-3253): remove error_logs

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4025319 View commit details
    Browse the repository at this point in the history

  18. fix(ZMS-3253): refactor function logic getDateTimeRangeFromList to on… 

    …e place
    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    95dcef0 View commit details
    Browse the repository at this point in the history

  19. Merge remote-tracking branch 'origin/next' into bugfix-zms-3253-valid… 

    …ation-opening-hours-of-the-same-appointment-type-must-not-overlap
    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    39ef3a6 View commit details
    Browse the repository at this point in the history

  20. fix(ZMS-3253): renable twig cache

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3eb8912 View commit details
    Browse the repository at this point in the history

  21. fix(ZMS-3253): renable twig cache

    Tom Fink authored and Tom Fink committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    46c0af9 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fdd0c72 View commit details
    Browse the repository at this point in the history

  2. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f319de3 View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b8fd6b6 View commit details
    Browse the repository at this point in the history

  4. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a2691c1 View commit details
    Browse the repository at this point in the history

  5. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fc26e13 View commit details
    Browse the repository at this point in the history

  6. fix(ZMS-3253): fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    bffc9fa View commit details
    Browse the repository at this point in the history

  7. fix(ZMS-3253): try fix unit test

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5784eb4 View commit details
    Browse the repository at this point in the history

  8. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    51e25ca View commit details
    Browse the repository at this point in the history

  9. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4f2a125 View commit details
    Browse the repository at this point in the history

  10. fix(ZMS-3253): remove space

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e8cae55 View commit details
    Browse the repository at this point in the history

  11. fix(ZMS-3253): remove space

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e0f4fa6 View commit details
    Browse the repository at this point in the history

  12. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d17ffa2 View commit details
    Browse the repository at this point in the history

  13. fix(ZMS-3253): add unit tests for testing validation availability ope… 

    …ning hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8a41469 View commit details
    Browse the repository at this point in the history

  14. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e230b26 View commit details
    Browse the repository at this point in the history

  15. fix(ZMS-3253): add unit tests for testing validation availability ope… 

    …ning hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5aadb7b View commit details
    Browse the repository at this point in the history

  16. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    246b4d1 View commit details
    Browse the repository at this point in the history

  17. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    17dcb07 View commit details
    Browse the repository at this point in the history

  18. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e984774 View commit details
    Browse the repository at this point in the history

  19. fix(ZMS-3253): add unit tests for testing overlapping availability op… 

    …ening hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d5135e2 View commit details
    Browse the repository at this point in the history

  20. fix(ZMS-3253): add unit tests for testing validation availability ope… 

    …ning hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ca99ef2 View commit details
    Browse the repository at this point in the history

  21. fix(ZMS-3253): add unit tests for testing validation availability ope… 

    …ning hours
    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d5c6051 View commit details
    Browse the repository at this point in the history

  22. fix(ZMS-3253): refactor object creation

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5527c58 View commit details
    Browse the repository at this point in the history

  23. fix(ZMS-3253): refactor exception messages

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ad89835 View commit details
    Browse the repository at this point in the history

  24. fix(ZMS-3253): clean up commented code

    @ThomasAFink
    ThomasAFink committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2a7d978 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. fix(ZMS-3253): fix grammar

    @ThomasAFink
    ThomasAFink committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ea55b27 View commit details
    Browse the repository at this point in the history

  2. fix(ZMS-3253): comment error_log

    @ThomasAFink
    ThomasAFink committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    932fe5f View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-3253): Improve frontend validation for opening hours availabi… 

    …lity
    @ThomasAFink
    ThomasAFink committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5aa9d6b View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. cleanup(ZMS-3415): remove invalid text instruction for graph view ope… 

    …ning hours
    @ThomasAFink
    ThomasAFink committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fb7efb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. fix(ZMS-1891): Add missing frontend validation for timepicker

    Thomas Fink authored and Thomas Fink committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1fd8f65 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into bugfix-zms-3253-validation-opening-hours-of-… 

    …the-same-appointment-type-must-not-overlap
    Thomas Fink authored and Thomas Fink committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f8f536f View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-1891): Improve frontend validation for time formats

    Thomas Fink authored and Thomas Fink committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e4981ff View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. fix(ZMS-3253): fix frontend exclusion availability validation

    @ThomasAFink
    ThomasAFink committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    7916a70 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. fix(ZMS-3253): fix backend exclusion availability validation

    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    462be60 View commit details
    Browse the repository at this point in the history

  2. fix(ZMS-3253): allow exclusion availability on current date

    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    46db273 View commit details
    Browse the repository at this point in the history

  3. fix(ZMS-3253): improve validation and cleanup code

    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    490ddce View commit details
    Browse the repository at this point in the history

  4. fix(ZMS-3253): move js spinner

    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    2ce2363 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/next' into bugfix-zms-3253-valid… 

    …ation-opening-hours-of-the-same-appointment-type-must-not-overlap
    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    735c579 View commit details
    Browse the repository at this point in the history

  6. clean(ZMS-3253): remove console logs

    @ThomasAFink
    ThomasAFink committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    97cee9c View commit details
    Browse the repository at this point in the history