Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sandbox): webpack bundle analyzer testing - don't merge #1102

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Fupete
Copy link
Collaborator

@Fupete Fupete commented Nov 24, 2023

This branch is just for testing purpose.
Following this approach I installed this plugin. Locally, on localhost:3001 you can browse the visualization...

First impression: video.js module seems huge compared to the other ones. See also this issue.

Let's explore this @bfabio @astagi next months.

@Fupete Fupete changed the title feat(don't merge!): webpack bundle analyzer testing feat(test): webpack bundle analyzer testing (don't merge) Nov 24, 2023
@Fupete Fupete added dependencies Pull requests that update a dependency file enhancement labels Nov 24, 2023
@Fupete Fupete marked this pull request as draft November 24, 2023 12:50
@Fupete Fupete requested a review from bfabio November 24, 2023 12:55
@bfabio
Copy link
Member

bfabio commented Nov 24, 2023

See also: #851

Note that we can look at the bundle size in the Lighthouse check in every PR, with this button (View Treemap):
image

f.e. https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1700828628455-94358.report.html

@Fupete Fupete requested a review from astagi November 24, 2023 12:55
@Fupete
Copy link
Collaborator Author

Fupete commented Nov 24, 2023

@bfabio yes, cool. However the plugin above works in dev mode too... could be useful for quick testing I think.

Copy link
Contributor

github-actions bot commented Nov 24, 2023

⚡ Lighthouse report for the home page 🏠

Category Score
🟠 Performance 66
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

See the full report...

Other pages

@Fupete Fupete changed the title feat(test): webpack bundle analyzer testing (don't merge) feat(sandbox): webpack bundle analyzer testing - don't merge Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
Status: 🛠 Doing
Development

Successfully merging this pull request may close these issues.

2 participants