Bug fix for building scenario with schematron. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the build, the schematron validation will be added when a schematron is provided in the schematron builder. To ensure the Transformation has been added to the list, the field schematronValidations should be set. Simply return an empty list will in the end ignore the provided schematron.
|
The behavior that simply return an empty list is however still wrong, this is because: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of v1.5.0 contains a bug which prevents building a scenario with schematron via the API:
In function Scenario.getSchematronValidations the function returns an empty list when there are no schematronValidations. But the return value
Collections.emptyList()is an immutable list which can not perform add method. This getter will be called in ScenarioBuilder.buildSchematron with an add operation to add the build result, which leads to anUnsupportedOperationExceptionThis pull request did the bug fix and add the test case for this case.