Public Join - Elapsed time check #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `Missiles` to `sdk.unittype`. Added Missiles Data to `GameData`. Refactored Prototypes to use `defineProperty` instead of `__defineGetter__` and be enumerable properties. Removed duplicate declaration of `unit` getter for `PresetUnit` class. Added `moveBy` function to Unit prototype. Added GeneticAlgorithmAttack bot script. Added `missiles.txt` and `monstats.txt` sdk files from d2 mpq data.
Added `PublicJoinMaxElapsedTime` property in StarterConfig of D2BotPubJoin. Added functions to retrieve the elapsed time of a game in the public games list in `OOG.js`.
Merged
|
Normally i wouldnt like merging it directly to master, But eh. not much comes with it now, lets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
PublicJoinMaxElapsedTimeproperty in StarterConfig of D2BotPubJoin.Added functions to retrieve the elapsed time of a game in the public games list in
OOG.js.This PR is a copy/paste of my PR from kolton repo : kolton/d2bot-with-kolbot#985
Usage
In your char config :
Config.StarterConfig.PublicJoinMaxElapsedTime = 60; // secondsBot will not join public games which elapsed time is greater than this value. Set
-1to disable.