Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please promote Tags TCK https://download.eclipse.org/jakartaee/tags/3.0/jakarta-tags-tck-3.0.1.zip #762

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 2235ed8
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/668c331c7bad150008270d5d
😎 Deploy Preview https://deploy-preview-762--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scottmarlow scottmarlow changed the title Please promote TCK Please promote Tags TCK https://download.eclipse.org/jakartaee/tags/3.0/jakarta-tags-tck-3.0.1.zip Jul 8, 2024
@scottmarlow scottmarlow marked this pull request as draft July 8, 2024 20:09
@scottmarlow
Copy link
Contributor Author

@pnicolucci could you please check that this pull request for updating the https://jakarta.ee/specifications/tags/3.0/ page looks correct to you?
Mostly, you just need to review this link and browse to Specifications and choose Tags (3.0) and look at the updated TCK link. Thanks!

@scottmarlow scottmarlow marked this pull request as ready for review July 9, 2024 12:44
@ivargrimstad
Copy link
Member

@scottmarlow Where can I find the file to promote? I just don't want to promote the wrong file

@arjantijms
Copy link
Contributor

arjantijms commented Jul 9, 2024

The file to promote seemingly has not been generated by the JSTL CI:

https://ci.eclipse.org/jstl

So I wonder where "jakarta-tags-tck-3.0.1.zip" came from then.

EDIT: I see the Tags (JSTL) TCK has not been moved to https://github.com/jakartaee/tags yet, so the release would be done from the main http://ci.eclipse.org/jakartaee-tck CI.

@scottmarlow
Copy link
Contributor Author

@scottmarlow Where can I find the file to promote? I just don't want to promote the wrong file

@ivargrimstad Sorry about that, the TCK zip is https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-tags-tck-3.0.1.zip

@ivargrimstad
Copy link
Member

I am waiting for the Jenkins to come back online after being restarted, but I will promote this and the others as soon as possible.

@ivargrimstad
Copy link
Member

@ivargrimstad ivargrimstad merged commit 67ed1af into jakartaee:master Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants