Updates to stage the core profile 11.0.0 release #782
Conversation
Signed-off-by: Scott M Stark <[email protected]>
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The 11.0.0 core proflie tck has been respun and this is the updated bundle info for the staged eftl binary: The maven artifacts are also staged with repository ID jakartatck-1111.
|
|
Hi @starksm64, Here are the core profile specification documents (PDF and HTML) for you to add to the PR. |
Signed-off-by: Scott M Stark <[email protected]>
|
@ivargrimstad those have been added. It looks like the final apidocs are still needed. |
|
The API docs are in a separate PR. |
|
Ok, then should be good to go. |
|
@starksm64 the TCK is missing from the deployed view. Please see the Jakarta Core Profile 10.0 TCK (sig, sha, pub)) |
|
The software requirement was wrong:
|
|
The examples folder |
|
The TCK license is:
Just double checking that we do not require v 1.1 to be used at https://www.eclipse.org/legal/tck/. |
|
TCK reference guide section 3.2 has the wrong EE version
|
|
@starksm64 please address all of the above comments from me and @tjwatson |
Signed-off-by: Scott M Stark <[email protected]>
|
The remaining changes are going to require another respin of the coreprofile tck. |
|
Thanks @starksm64 |
|
Thanks @starksm64! Can you also list the two compatible implementations used for ratification (as is done for Core Profile 10)?
|
Signed-off-by: Scott M Stark <[email protected]>
I added the names, if we want the links to the downloads that will need to be added. |
|
By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone. |
Has the TCK been updated again? They both have been respun once. |
Ah, I see it now. The updates to the user guide etc... I'll back the approved label from the CCRs so it Is reflected there |
|
The 11.0.0 core profile has been respun again and has been staged and uploaded to the project download area. The new info is: The maven artifacts are also staged with repository ID jakartatck-1112.
|
This was updated to 1.1 since I had to update the TCK anyway |
|
@starksm64 the complication implementations missed the links |
coreprofile/11/_index.md
Outdated
| [sha](https://download.eclipse.org/jakartaee/coreprofile/11/jakarta-core-profile-tck-11.0.0.zip.sha256), | ||
| [pub](https://jakarta.ee/specifications/jakartaee-spec-committee.pub)) | ||
| --> | ||
| * Compatible Implementations used for [ratification](https://www.eclipse.org/projects/efsp/?version=1.2#efsp-ratification). | ||
| * WildFly |
coreprofile/11/_index.md
Outdated
| --> | ||
| * Compatible Implementations used for [ratification](https://www.eclipse.org/projects/efsp/?version=1.2#efsp-ratification). | ||
| * WildFly | ||
| * Open Liberty |
There was a problem hiding this comment.
If this is the only thing stopping the release review from starting, I think we can go ahead with it. The links can be added after completion.
There was a problem hiding this comment.
I prefer to have the link added according to the review process. Besides, people can cast their vote can be confident with their vote. It is so easy to fix.
This was not fixed in the readme doc and in the core profile jar. It should be Java SE 17+ runtime in the core profile tck zip. @starksm64 |
Considering the issue is so minor, I am okay not to do the respin and have this fixed in the next release. If you agree, please go ahead to open an issue to track this in the relevant repo @starksm64 |
|
If you pull down the build tck, which is same as the staged tck, https://ci.eclipse.org/jakartaee-tck/job/11/job/jakarta-core-profile-tck-maven-central/14/artifact/platform-tck/core-profile-tck/tck-dist/target/jakarta-core-profile-tck-11.0.0.zip this is what the requirements section says in both the core-profile-tck-11.0.0/doc/core-profile-tck-reference-guide.pdf 3.4. The TCK Environment Are you seeing this somewhere else?
|
@starksm64 inside the core-profile-tck-11.0.0.zip, the readme.adoc was not updated. As I mentioned earlier, it is so minor and it can be fixed in the next release. |
Co-authored-by: Emily Jiang <[email protected]>
Co-authored-by: Emily Jiang <[email protected]>
|
An issue to remove the requirements statements from the readme (where the old ref to Java SE 11 is) has been created: |
| * [Jakarta EE 11 core profile Specification Document](./jakarta-coreprofile-spec-11.0.pdf) (PDF) | ||
| * [Jakarta EE 11 core profile Specification Document](./jakarta-coreprofile-spec-11.0.html) (HTML) |
There was a problem hiding this comment.
I think it would be better if "core profile" here was capitalised. This would better align it with the usage in the other bullet points
| * [Jakarta EE 11 core profile Specification Document](./jakarta-coreprofile-spec-11.0.pdf) (PDF) | |
| * [Jakarta EE 11 core profile Specification Document](./jakarta-coreprofile-spec-11.0.html) (HTML) | |
| * [Jakarta EE 11 Core Profile Specification Document](./jakarta-coreprofile-spec-11.0.pdf) (PDF) | |
| * [Jakarta EE 11 Core Profile Specification Document](./jakarta-coreprofile-spec-11.0.html) (HTML) |
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee11/staged/eftl/jakarta-core-profile-tck-11.0.0.zip
*** SHA256SUM: 5722bac4f1af78e93ede95feaa448aa0bc19934d0871415c25dd45ffa8c5d1a5 ***
- Compatibility certification request for Open Liberty for Jakarta EE 11, Core Profile platform#975
- Compatibility certification request for WildFly Preview for Jakarta EE 11 Core Profile platform#978
Note: If any item does not apply, check it and mark N/A below it.
Below are for Jakarta EE Specification Committee
Mentor Spec Review Checklist
certificationlabel.If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to [email protected].
(A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)
Update Jakarta EE API jar
Mentor Final Tasks after a Successful Release Review
approvedlabel to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email listusing the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
(an example can be found here.)