Fixed #137 - REPL was not working if Atom Ink wasn't installed.

jasongilman · Aug 11, 2016 · 08a9145 · 08a9145
1 parent 04e4bc6
commit 08a9145
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -380,3 +380,7 @@ Accidentally published as major instead of minor but oh well! Now is as good a t
   * Updating REPL instructions.
   * Fixing sizing of result output.
   * Fixing REPL history.
+
+# 1.4.2
+
+* Fixed #137 - REPL was not working if Atom Ink wasn't installed.
diff --git a/lib/proto-repl.coffee b/lib/proto-repl.coffee
@@ -217,8 +217,7 @@ module.exports = ProtoRepl =
       @repl.startProcessIfNotRunning(projectPath)
 
   prepareRepl: (repl)->
-    if @ink
-      repl.consumeInk(@ink)
+    repl.consumeInk(@ink)
     repl.onDidClose =>
       @repl = null
     repl.onDidStart =>

diff --git a/lib/repl.coffee b/lib/repl.coffee
@@ -45,7 +45,7 @@ class Repl
   consumeInk: (ink)->
     @ink = ink
 
-    if atom.config.get("proto-repl.inkConsole")
+    if @ink && atom.config.get("proto-repl.inkConsole")
       @replView = new InkConsole(@ink)
     else
       @replView = new ReplTextEditor()
@@ -54,6 +54,10 @@ class Repl
       # Display the help text when the repl opens.
       if atom.config.get("proto-repl.displayHelpText")
         @info(replHelpText)
+      # Warn if Atom Ink is not installed.
+      if !@ink && atom.config.get("proto-repl.inkConsole")
+        @info("Atom Ink does not appear to be installed. Install it to get a better REPL experience.")
+
 
     # The window was closed
     @replView.onDidClose =>