This repository has been archived by the owner on May 10, 2023. It is now read-only.
improve the output format of print-var-documentation #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the output of the print-var-documentation command.
current output:
new output:
The current code also depends on the stdout coming back to through the repl connection, which may not always happen. (It doesn't with the shadow-cljs repl I'm using.) The new code uses with-out-str to get the doc output through the return value.
I also added an
allSessions
option toNReplConnection.sendCommand
to make it easier to switch all sessions to ClojureScript when using shadow-cljs or piggyback. This is needed because the new doc command usesdisplayInRepl: false
and so the command goes tocmdSession
instead ofsession
. Users can define commands like this in their init.coffee / init.js to switch between Clojure and ClojureScript repls: