-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add truncate option to flush command #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 95.21% 95.47% +0.25%
==========================================
Files 31 32 +1
Lines 1025 1083 +58
==========================================
+ Hits 976 1034 +58
Misses 49 49 ☔ View full report in Codecov by Sentry. |
Thanks @BinDruid for this PR. I left some comments. Please address the coverage as well. |
@hramezani |
Thanks @BinDruid for the update. Please add a change log entry in CHANGELOG.md. Sorry, I forgot to mention it before. |
@hramezani Thanks for the heads up! |
Thanks @BinDruid |
Fixes #680
Passing
--truncate
to flush command executes a truncate SQL statement, instead of deleting log records.