Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add truncate option to flush command #681

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

BinDruid
Copy link
Contributor

Fixes #680
Passing --truncate to flush command executes a truncate SQL statement, instead of deleting log records.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (5289482) to head (9b3eb2e).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   95.21%   95.47%   +0.25%     
==========================================
  Files          31       32       +1     
  Lines        1025     1083      +58     
==========================================
+ Hits          976     1034      +58     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member

Thanks @BinDruid for this PR. I left some comments. Please address the coverage as well.
Then we are good to merge it.

@BinDruid
Copy link
Contributor Author

@hramezani
I refactored the TruncateQuery class and added another test case to cover unsupported databases.

@hramezani
Copy link
Member

hramezani commented Oct 21, 2024

Thanks @BinDruid for the update.

Please add a change log entry in CHANGELOG.md.

Sorry, I forgot to mention it before.

@BinDruid
Copy link
Contributor Author

@hramezani Thanks for the heads up!
I have updated change log to include info about truncate option addition.

@hramezani hramezani merged commit b1ecc8f into jazzband:master Oct 21, 2024
7 checks passed
@hramezani
Copy link
Member

Thanks @BinDruid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new option to truncate log entries when calling flush command
2 participants