Fix migrations when used in condition with a custom DB. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niall-madecurious Thanks for the contribution! I'll review it in the next few days. |
giovannicimolin
approved these changes
Oct 10, 2023
|
@niall-madecurious I still don't have access to the pypi package, so I can't create a new release. |
|
Thanks @giovannicimolin for the notice on release issues. I'll follow #304 and pull from git for now. |
dontexit
pushed a commit
to dontexit/django-rest-knox
that referenced
this pull request
Jan 24, 2024
…ustom-db Fix migrations when used in condition with a custom DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently picked up Knox to use it within one of our projects that uses custom databases during its testing steps. While our setup isn't the most common. it is supported by Django. Unfortunately when using a custom DB the
0006_auto_20160818_0932.pyfails to run because the ORM call doesn't respect the schemas DB connection.The fix included here just sets the connection alias to respect that configured by the schema. This doesn't effect anyone using the standard DB and doesn't effect anyone who already has the migration install, however allows users with a custom DB connection to now run the migration.
Thanks for the great package you provide. Please let me know if you require any further clarification.