WAF remove volatile from isDisposed fields as this is not needed

jbe2277 · Sep 24, 2023 · ff7ba67 · ff7ba67
1 parent 7ba17f4
commit ff7ba67
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/System.Waf/System.Waf/System.Waf.Core/Foundation/ObservableListViewCore.cs b/src/System.Waf/System.Waf/System.Waf.Core/Foundation/ObservableListViewCore.cs
@@ -19,7 +19,7 @@ public class ObservableListViewCore<T> : ObservableListViewBase<T>, IDisposable
         private readonly bool noCollectionChangedHandler;
         private Predicate<T>? filter;
         private Func<IEnumerable<T>, IOrderedEnumerable<T>>? sort;
-        private volatile int isDisposed;
+        private int isDisposed;
 
         /// <summary>Initializes a new instance of the ObservableListView class that represents a view of the specified list.</summary>
         /// <param name="originalList">The original list.</param>

diff --git a/src/System.Waf/System.Waf/System.Waf.Core/Foundation/SynchronizingCollectionCore.cs b/src/System.Waf/System.Waf/System.Waf.Core/Foundation/SynchronizingCollectionCore.cs
@@ -24,7 +24,7 @@ public class SynchronizingCollectionCore<T, TOriginal> : ReadOnlyObservableList<
         private readonly IEqualityComparer<T> itemComparer;
         private readonly IEqualityComparer<TOriginal> originalItemComparer;
         private readonly bool noCollectionChangedHandler;
-        private volatile int isDisposed;
+        private int isDisposed;
 
         /// <summary>Initializes a new instance of the <see cref="SynchronizingCollectionCore{T, TOriginal}"/> class.</summary>
         /// <param name="originalCollection">The original collection.</param>

diff --git a/src/System.Waf/System.Waf/System.Waf.Core/Presentation/Services/SettingsServiceCore.cs b/src/System.Waf/System.Waf/System.Waf.Core/Presentation/Services/SettingsServiceCore.cs
@@ -21,7 +21,7 @@ public class SettingsServiceCore : ISettingsService, IDisposable
 
         private readonly ConcurrentDictionary<Type, Lazy<object>> settings;
         private string fileName;
-        private volatile int isDisposed;
+        private int isDisposed;
 
         /// <summary>Initializes a new instance of the SettingsService.</summary>
         public SettingsServiceCore()

diff --git a/src/System.Waf/System.Waf/System.Waf.UnitTesting.Core/UnitTestSynchronizationContext.cs b/src/System.Waf/System.Waf/System.Waf.UnitTesting.Core/UnitTestSynchronizationContext.cs
@@ -9,7 +9,7 @@ public sealed class UnitTestSynchronizationContext : SynchronizationContext, IDi
     {
         private readonly SynchronizationContext? previousContext;
         private readonly BlockingCollection<(SendOrPostCallback callback, object? state)> messageQueue;
-        private volatile int isDisposed;
+        private int isDisposed;
 
         private UnitTestSynchronizationContext()
         {