Decode subprocess output #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When export fails the output should be messaged to the user. This
however did not work on Python 3 because the result of p.communicate()
is a tuple of bytes and join() expects strings. This lead to the error:
TypeError: sequence item 0: expected str instance, bytes found
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 49 49
Lines 6794 6794
=======================================
Hits 5733 5733
Misses 1061 1061
Continue to review full report at Codecov.
|
akstrfn
suggested changes
Dec 11, 2017
| @@ -81,7 +81,9 @@ def _export(cls, format_): | |||
| p.wait() | |||
|
|
|||
| if p.returncode != 0 or settings.get(u'org_export_verbose') == 1: | |||
| echom('\n'.join(p.communicate())) | |||
| echom('\n'.join(map( | |||
There was a problem hiding this comment.
Use u_decode function from here.
So something like map(u_decode, p.communicate())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When export fails the output should be messaged to the user. This
however did not work on Python 3 because the result of p.communicate()
is a tuple of bytes and join() expects strings. This lead to the error: