Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added environment variable functionality #117

Open
wants to merge 115 commits into
base: master
Choose a base branch
from
Open

Added environment variable functionality #117

wants to merge 115 commits into from

Conversation

vikulin
Copy link

@vikulin vikulin commented Oct 11, 2018 •
edited
Loading

Added new functionality

  • environment variable can receive artifacts URLs

@vikulin
Copy link
Author

vikulin commented May 3, 2020

This helpful change has been implemented accordingly to my production CI server task. I needed to send published s3 links to Slack channel. As result I have implemented these functionality using InjectEnvPlugin. Please review my work.

Thanks.

@vikulin vikulin closed this May 3, 2020
@vikulin vikulin reopened this May 3, 2020
@vikulin
Copy link
Author

vikulin commented Apr 23, 2021

Any updates?

@vikulin
Copy link
Author

vikulin commented Apr 23, 2021

@olivergondza , can you please review my pull request?

@vikulin
Copy link
Author

vikulin commented Apr 23, 2021

2021-04-23_18h47_48

@vikulin
Copy link
Author

vikulin commented Jul 28, 2021

@alecharp, can you please review my changes?

vikulin and others added 8 commits November 19, 2021 14:25
@vikulin
Merged changes from parent repo
b9ea463
@vikulin
Merge branch 'jenkinsci-master' into HEAD
783da0d
@vikulin
Merge branch 'jenkinsci-master-1'
e45cc55
@dependabot
Bump bom-2.289.x from 961.vf0c9f6f59827 to 1008.vb9e22885c9cf
61ad722 
Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 961.vf0c9f6f59827 to 1008.vb9e22885c9cf.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.289.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump testcontainers from 1.16.0 to 1.16.2
7b5b04d 
Bumps [testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.16.0 to 1.16.2.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.16.0...1.16.2)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump aws-java-sdk-minimal from 1.12.80 to 1.12.101-300.vc09c7be9cb57
88ff2e0 
Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.80 to 1.12.101-300.vc09c7be9cb57.
- [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases)
- [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/aws-java-sdk-plugin@aws-java-sdk-parent-1.12.80...1.12.101-300.vc09c7be9cb57)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
1. added secure domain link
af33517
@vikulin
removed unused method
30c0000
@vikulin
Copy link
Author

vikulin commented Nov 19, 2021

@rsandell , please review my changes.

alecharp
alecharp requested changes Nov 19, 2021
View reviewed changes
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, the current PR has a lot of noise, which is distracting from reviewing it's purpose. Please, see my few comments and once addressed, I'll review the core of the PR.

pom.xml Outdated Show resolved Hide resolved
.project Show resolved Hide resolved
src/main/java/hudson/plugins/s3/ClientHelper.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/Destination.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/Entry.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/S3BucketPublisher.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/S3BucketPublisher.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/Uploads.java Outdated Show resolved Hide resolved
src/main/resources/hudson/plugins/s3/Entry/config.jelly Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/s3/S3BucketPublisher.java Outdated Show resolved Hide resolved
dependabot bot and others added 30 commits June 2, 2022 08:26
@dependabot
Bump maven-plugin from 3.18 to 3.19
361a59c 
Bumps [maven-plugin](https://github.com/jenkinsci/maven-plugin) from 3.18 to 3.19.
- [Release notes](https://github.com/jenkinsci/maven-plugin/releases)
- [Changelog](https://github.com/jenkinsci/maven-plugin/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/maven-plugin@maven-plugin-3.18...maven-plugin-3.19)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.main:maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #61 from vikulin/dependabot/maven/org.jenkins-ci.m…
4ee30f1 
…ain-maven-plugin-3.19

Bump maven-plugin from 3.18 to 3.19
@dependabot
Bump aws-java-sdk-minimal
09e6d9c 
Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.215-339.vdc07efc5320c to 1.12.246-349.v96b_b_f7eb_a_c3c.
- [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases)
- [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jenkinsci/aws-java-sdk-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump testcontainers from 1.17.2 to 1.17.3
2a54c8c 
Bumps [testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.17.2 to 1.17.3.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.17.2...1.17.3)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump plugin from 4.40 to 4.42
2618a83 
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.40 to 4.42.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.40...plugin-4.42)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump bom-2.289.x from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6
8c9abd2 
Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.289.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #71 from vikulin/dependabot/maven/io.jenkins.tools…
3e2d383 
….bom-bom-2.289.x-1472.vb_65d893c9a_b_6

Bump bom-2.289.x from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6
@vikulin
Merge pull request #70 from vikulin/dependabot/maven/org.jenkins-ci.p…
28575d5 
…lugins-plugin-4.42

Bump plugin from 4.40 to 4.42
@dependabot
Bump bom-2.289.x from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43
2283e27 
Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.289.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #72 from vikulin/dependabot/maven/io.jenkins.tools…
c2d146c 
….bom-bom-2.289.x-1478.v81d3dc4f9a_43

Bump bom-2.289.x from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43
@dependabot
Bump plugin from 4.42 to 4.43.1
179c90c 
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.42 to 4.43.1.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.42...plugin-4.43.1)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #73 from vikulin/dependabot/maven/org.jenkins-ci.p…
f17cd30 
…lugins-plugin-4.43.1

Bump plugin from 4.42 to 4.43.1
@dependabot
Bump bom-2.289.x from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975
d1a463a 
Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.289.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #74 from vikulin/dependabot/maven/io.jenkins.tools…
a0d5ad8 
….bom-bom-2.289.x-1500.ve4d05cd32975

Bump bom-2.289.x from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975
@dependabot
Bump plugin from 4.43.1 to 4.45
41242a7 
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.43.1 to 4.45.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.43.1...plugin-4.45)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump envinject from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec
f75bfc4 
Bumps [envinject](https://github.com/jenkinsci/envinject-plugin) from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec.
- [Release notes](https://github.com/jenkinsci/envinject-plugin/releases)
- [Changelog](https://github.com/jenkinsci/envinject-plugin/blob/master/docs/CHANGELOG_OLD.md)
- [Commits](https://github.com/jenkinsci/envinject-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:envinject
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #76 from vikulin/dependabot/maven/org.jenkins-ci.p…
47bd1c2 
…lugins-plugin-4.45

Bump plugin from 4.43.1 to 4.45
@vikulin
Merge pull request #77 from vikulin/dependabot/maven/org.jenkins-ci.p…
685cb9d 
…lugins-envinject-2.875.v9b_9e962da_a_ec

Bump envinject from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec
@dependabot
Bump plugin from 4.45 to 4.46
0366ef4 
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.45 to 4.46.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.45...plugin-4.46)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #78 from vikulin/dependabot/maven/org.jenkins-ci.p…
6739efe 
…lugins-plugin-4.46

Bump plugin from 4.45 to 4.46
@dependabot
Bump copyartifact from 1.46.4 to 1.47
00c0d03 
Bumps [copyartifact](https://github.com/jenkinsci/copyartifact-plugin) from 1.46.4 to 1.47.
- [Release notes](https://github.com/jenkinsci/copyartifact-plugin/releases)
- [Changelog](https://github.com/jenkinsci/copyartifact-plugin/blob/master/CHANGELOG.adoc)
- [Commits](jenkinsci/copyartifact-plugin@copyartifact-1.46.4...copyartifact-1.47)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:copyartifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #79 from vikulin/dependabot/maven/org.jenkins-ci.p…
1732a88 
…lugins-copyartifact-1.47

Bump copyartifact from 1.46.4 to 1.47
@vikulin
Merge pull request #68 from vikulin/dependabot/maven/org.testcontaine…
ddca990 
…rs-testcontainers-1.17.3

Bump testcontainers from 1.17.2 to 1.17.3
@vikulin
Merge pull request #65 from vikulin/dependabot/maven/org.jenkins-ci.p…
4764866 
…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.246-349.v96b_b_f7eb_a_c3c

Bump aws-java-sdk-minimal from 1.12.215-339.vdc07efc5320c to 1.12.246-349.v96b_b_f7eb_a_c3c
@dependabot
Bump release-drafter/release-drafter from 5.20.0 to 5.20.1
0df1573 
Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.20.0 to 5.20.1.
- [Release notes](https://github.com/release-drafter/release-drafter/releases)
- [Commits](release-drafter/release-drafter@v5.20.0...v5.20.1)

---
updated-dependencies:
- dependency-name: release-drafter/release-drafter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #80 from vikulin/dependabot/github_actions/release…
4a623f7 
…-drafter/release-drafter-5.20.1

Bump release-drafter/release-drafter from 5.20.0 to 5.20.1
@dependabot
Bump plugin from 4.46 to 4.47
950ff1b 
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.46 to 4.47.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.46...plugin-4.47)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #81 from vikulin/dependabot/maven/org.jenkins-ci.p…
172315e 
…lugins-plugin-4.47

Bump plugin from 4.46 to 4.47
@dependabot
Bump aws-java-sdk-minimal
8392b43 
Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.246-349.v96b_b_f7eb_a_c3c to 1.12.287-357.vf82d85a_6eefd.
- [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases)
- [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jenkinsci/aws-java-sdk-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@vikulin
Merge pull request #82 from vikulin/dependabot/maven/org.jenkins-ci.p…
6ecc873 
…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.287-357.vf82d85a_6eefd

Bump aws-java-sdk-minimal from 1.12.246-349.v96b_b_f7eb_a_c3c to 1.12.287-357.vf82d85a_6eefd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecharp alecharp Awaiting requested review from alecharp

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikulin @alecharp