-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow assume role #129
base: master
Are you sure you want to change the base?
Allow assume role #129
Conversation
INFRA-3043 Approved-by: Andrew Newell <[email protected]> Approved-by: Lew Gordon <[email protected]>
INFRA-3120 Approved-by: Tim Hawes <[email protected]> Approved-by: Lew Gordon <[email protected]>
This is a feature requirement for our setup where Jenkins is running on a EC2 instance and the plugin needs to be able to upload to a bucket in another account via AWS's assume role capability. |
#116 also adds the capability to assign a canned ACL for uploaded objects, useful when using S3 to host static web assets. |
I've build the patched fork and installed that version of the plugin on a test Jenkins instance.
|
@anthonygreen Yeah, I definitely think I need more docs on this. Currently we use it internally on our Jenkins so I haven't given much thought to it. If you want to just have the profile assume the role, you need to specify the role under "Assume IAM Role" and NOT check the "Use IAM Role" box. When clicking away you should see some validation if the master is able to assume the IAM role. If that doesn't work there's probably some bug somewhere in my fork that I need to fix. :) |
Is there any prospect of these changes being updated so they can be easily merged into a fork of the current head of jenkinsci:master ? |
Sorry, I didn't check for existing open PRs when I did #138 I believe this could be made less complex when applied on top of that. |
Offhand I would expect this sort of thing to be handled by the |
May duplicate #116 . Many times we'll need to assume a role as specifying a user's credentials doesn't work in most of our cases since we'll require a security token.