Add supporting S3 tags #294
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * The key of the user tag pair to tag an upload with. | ||
| * Can contain macros. | ||
| */ | ||
| public String key; |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Plaintext password storage Warning
There was a problem hiding this comment.
Can this field contains confidential information?
From what I understand, no, so security alert is not true.
|
Hi, it looks like something happened yesterday with |
|
@alecharp could you please have a look? |
There was a problem hiding this comment.
I'm wondering if you could check what happens when you try to upload a file with this changeset but with the old configuration in. Basically, using the default branch code, configure a job to to an upload to s3, then using this changeset run the job without touching the configuration.
| * The key of the user tag pair to tag an upload with. | ||
| * Can contain macros. | ||
| */ | ||
| public String key; |
There was a problem hiding this comment.
Can this field contains confidential information?
From what I understand, no, so security alert is not true.
gilgameshfreedom
force-pushed
the
support-s3-tags
branch
from
306ef00 to
5fe9b90
Compare
|
So I've run a Jenkins instance with s3-plugin pointed to the |
|
Hi @alecharp Anything else should I do regarding the PR? |
|
@alecharp up |
|
Hi @rsandell May I ask you review the PR? |
The PR is adding supporting of S3 tags - https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
Like S3 Metadata, S3 Tags is an optional list of key-values pairs which can be applied per object.
In our use-case with the s3-plugin + MinIO and we use special lifecycle polices which delete only the objects with a specific tag assigned.
To be able to test the plugin locally I had also to increase the version of jenkins to
2.414.3.