Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return more precise values for newer Envoys #70

Open
wants to merge 152 commits into
base: main
Choose a base branch
from
Open

Return more precise values for newer Envoys #70

wants to merge 152 commits into from

Conversation

gtdiehl
Copy link
Collaborator

@gtdiehl gtdiehl commented Apr 15, 2021 •
edited
Loading

Envoy-S return float values that are more precise as they have values 3 decimal points to the right. For these the API will return the actual value and not a rounded integer value

Fixes #55

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description.
  • Provide context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

DavidDeSloovere and others added 30 commits August 25, 2018 07:57
@DavidDeSloovere
Improve version detection
17693e0 
Also fix url
@jesserizzo
Merge pull request #2 from DavidDeSloovere/master
a636a5f 
Improve version detection
@jesserizzo
Improve detection of envoy model
cff6e6f
@jesserizzo
Bump request timeout to 10 seconds
58fd8f1
@jesserizzo
import EnvoyReader class instead of individual functions
c7b6c89
@jesserizzo
Skip call_api if we know the Envoy model doesn't support it
5926a81
@jesserizzo
Add support for Envoy IQ
6853105
@jesserizzo
Test for capabilities rather than state model name.
a6d7e5b
@jesserizzo
Bump version to 0.2
f3d21cb
@DavidDeSloovere
Merge pull request #1 from jesserizzo/master
d2c8a07 
Update from origin
@DavidDeSloovere
Fix detection of original Envoy model
2f69bee
@DavidDeSloovere
Cleanup error messages
169e6a8
@DavidDeSloovere
Update README.md
fe592a8
@DavidDeSloovere
Update README.md
223ddf8
@DavidDeSloovere
Make call more efficient for Envoy-C
adebb4d
@DavidDeSloovere
Merge branch 'master' of https://github.com/DavidDeSloovere/envoy_reader
a24ddbc
@DavidDeSloovere
text
3047393
@DavidDeSloovere
throw runtime error
cdb22ad
@DavidDeSloovere
single test instance
f47e58e
@DavidDeSloovere
test output formatting
58405d1
@DavidDeSloovere
Refactor endpoint check + error messages
5346430
@DavidDeSloovere
Fix tyop
1531ab6
@jesserizzo
Merge pull request #3 from DavidDeSloovere/master
eb3e641 
Fix Original Envoy detection
@jesserizzo
Fix error messages, increase network timeout
9ab6d21
@jesserizzo
bump version number
243f90a
@jesserizzo
Get production from individual inverters
3c0d45d
@jesserizzo
fix inverter production dictionary
bbd5eb0
Make reader async
f03d296
@jesserizzo
Fix formatting
f89ae9b
@jesserizzo
something
fa2b2db
gtdiehl and others added 29 commits December 28, 2020 13:03
@gtdiehl
Bump version to 0.18.2
77e5d1a
@gtdiehl
Merge pull request #59 from gtdiehl/master
1ba3d9d 
Add retries when gathering Inverter data
@gtdiehl
Fix indentation issue
0aa4561
@gtdiehl
Return None when inverters not supported
c4b1ab9
@gtdiehl
Bump version to 0.18.3
d6add6d
@gtdiehl
Merge pull request #61 from gtdiehl/master
b65fe5c 
Return None for Inverter data for Envoy with <3.9 firmware
@bdraco
Cleanup detection and avoid calling endpoints that are not present
64ef3cd 
- support passing in shared httpx client
- get pylint rating to 10/10
@bdraco
Remove httpx.HTTPError catch since response will be unbound on error
86300bf
@bdraco
reorder
ef48a4f
@bdraco
flake8 fixes
7bbf506
@bdraco
Add requirements
b0bbdc1
@bdraco
fix test location in ci
346e78c
@bdraco
prep work to install respx for testing
52c36d2
@bdraco
cleanup retry logic
37b1e38
@bdraco
Add more fixtures
fef68f5
@bdraco
fix v4
3e262ad
@bdraco
merge retry logic
ba1614b
@bdraco
Remove unused import
c3c4207
@bdraco
tweaks
71e9747
@bdraco
tests
00207f6
@bdraco
tests
36150fa
@gtdiehl
Merge pull request #64 from bdraco/detection_cleanups
df8e86c 
Cleanup detection and avoid calling endpoints that are not present
@gtdiehl
Bumping envoy_reader version
b528a92 
Bumping version for clean up in PR #64
@jesserizzo
Rename master to main (#66)
f611d5d 
* Rename master to main
@gtdiehl
Return more precise values for newer Envoys
3b62765 
Envoy-S return float values that are more precise as they have values 3 decimal points to the right. For these the API will return the actual value and not a rounded integer value
@gtdiehl
Changed detection of precise values
ec0355c 
Precise values only come when a CT is used.  When production metering is enabled the API returns a float, otherwise an integer is returned.
@gtdiehl
Trimming trailing zero when floating point is 0.0
96c3b1c
@gtdiehl
Updating tests
6550fa2 
Given directory names to indicate if Production/Consumption metering is enabled. Updated tests for new float values
@gtdiehl
Fixing black format issues
e4d4296
@gtdiehl gtdiehl requested a review from jesserizzo April 16, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesserizzo jesserizzo Awaiting requested review from jesserizzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Production and Consumption values are rounded for some Envoy devices
7 participants
@gtdiehl @DavidDeSloovere @jesserizzo @sfjes @dalklein @dennisdegreef @bdraco