Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fix linter errors with TypeScript declarations in Vitest setup instructions #696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaddyGuthridge
Copy link

ESLint (with the typescript-eslint plugin) gives a no-undef error without the <T = any> constraint in the type definitions. This PR adds the constraint to help prevent people from getting linting errors from the configuration. TypeScript doesn't seem to be fussed either way, but this should save people a minor annoyance.

What

Add type variable to TypeScript + Vitest setup instructions in the documentation.

Why

Prevent minor annoyances when linting fails for people who use the definitions.

ESLint gives a `no-undef` error without the `<T = any>` constraint in the type definition. This PR adds the constraint to help prevent people from getting linting errors from the configuration.
Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 9792571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant