added delete route53 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olisakov
force-pushed
the
delete-route53
branch
2 times, most recently
from
7c06f0a to
03bb625
Compare
tzvatot
reviewed
Sep 19, 2022
olisakov
force-pushed
the
delete-route53
branch
4 times, most recently
from
e9138a5 to
7a8534c
Compare
tbrisker
suggested changes
Sep 19, 2022
olisakov
force-pushed
the
delete-route53
branch
from
7a8534c to
7374b44
Compare
|
No dryRun option for this. Since @jharrington22 is maintainer, I'll delegate to him if this is a must or not. |
tbrisker
suggested changes
Sep 20, 2022
olisakov
force-pushed
the
delete-route53
branch
from
7374b44 to
a05b34e
Compare
tbrisker
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
LGTM, but we'll need @jharrington22 to approve as he owns this repo
|
We've decided to use aws-nuke instead. @jharrington22 FYI: https://github.com/rebuy-de/aws-nuke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jharrington22 @tzvatot @tbrisker PTAL
SDA-6849